From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:34322 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbeHTSxy (ORCPT ); Mon, 20 Aug 2018 14:53:54 -0400 Received: by mail-pf1-f193.google.com with SMTP id k19-v6so6957641pfi.1 for ; Mon, 20 Aug 2018 08:37:47 -0700 (PDT) Date: Mon, 20 Aug 2018 21:07:40 +0530 From: Himanshu Jha To: Jonathan Cameron Cc: David Frey , linux-iio@vger.kernel.org Subject: Re: [PATCH v3 3/7] iio: chemical: bme680: indent #defines consistently Message-ID: <20180820153740.GA3588@himanshu-Vostro-3559> References: <20180817190319.13119-1-dpfrey@gmail.com> <20180817190319.13119-4-dpfrey@gmail.com> <20180818110725.GD24920@himanshu-Vostro-3559> <20180819170215.35a6b1de@archlinux> <20180819172844.GC13175@himanshu-Vostro-3559> <20180819201439.30d318c7@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180819201439.30d318c7@archlinux> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Sun, Aug 19, 2018 at 08:14:39PM +0100, Jonathan Cameron wrote: > On Sun, 19 Aug 2018 22:58:44 +0530 > Himanshu Jha wrote: > > > On Sun, Aug 19, 2018 at 05:02:15PM +0100, Jonathan Cameron wrote: > > > On Sat, 18 Aug 2018 16:37:25 +0530 > > > Himanshu Jha wrote: > > > > > > > On Fri, Aug 17, 2018 at 12:03:15PM -0700, David Frey wrote: > > > > > Signed-off-by: David Frey > > > > > > > > Reviewed-by: Himanshu Jha > > > > Tested-by: Himanshu Jha > > > > > > > > Also, 0-day tested with build success! > > > > > > > > Thanks > > > > > > > > > > > > > > Applied, > > > > > > There is one more suspicious bit of indenting in here > > > #define BME680_REG_CTRL_GAS_1 0x71 > > > #define BME680_RUN_GAS_MASK BIT(4) > > > #define BME680_NB_CONV_MASK GENMASK(3, 0) > > > #define BME680_RUN_GAS_EN_BIT BIT(4) > > > #define BME680_NB_CONV_0_VAL 0 > > > > > > I think RUN_GAS_EN_BIT should be one level lower? > > > > No, its fine. It is a value and third level indent is expected. > > It should be set to 1 to initiate measurement. And > > the total mask value is > > 0b00001000 == BME680_RUN_GAS_EN_BIT | BME680_NB_CONV_0_VAL > > > Ah, then I'd argue it's name is wrong. BIT elsewhere has been used > to indicate a field in the register, not a value. > > Should probably just be BME680_RUN_GAS_EN? Sure. I will send a patch soon. -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology