From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] Revert "iio: temperature: maxim_thermocouple: add MAX31856 part"
Date: Sun, 2 Sep 2018 10:19:24 +0100 [thread overview]
Message-ID: <20180902101924.03f63471@archlinux> (raw)
In-Reply-To: <20180825090048.17438-1-matt.ranostay@konsulko.com>
On Sat, 25 Aug 2018 02:00:48 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> This reverts commit 535fba29b3e1afef4ba201b3c69a6992583ec0bd.
>
> Seems the submitter (er me, hang head in shame) didn't look at the datasheet
> enough to see that the registers are quite different.
>
> This needs to be reverted because a) would never work b) to open it be added
> to a Maxim RTDs (Resistance Temperature Detectors) under development by author
>
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Applied to the fixes-to greg branch of iio.git and marked for stable
so we avoid confusing people in the future.
Jonathan
> ---
> drivers/iio/temperature/maxim_thermocouple.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
> index 54e383231d1e..c31b9633f32d 100644
> --- a/drivers/iio/temperature/maxim_thermocouple.c
> +++ b/drivers/iio/temperature/maxim_thermocouple.c
> @@ -258,7 +258,6 @@ static int maxim_thermocouple_remove(struct spi_device *spi)
> static const struct spi_device_id maxim_thermocouple_id[] = {
> {"max6675", MAX6675},
> {"max31855", MAX31855},
> - {"max31856", MAX31855},
> {},
> };
> MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);
> --
> 2.17.1
>
prev parent reply other threads:[~2018-09-02 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 9:00 [PATCH] Revert "iio: temperature: maxim_thermocouple: add MAX31856 part" Matt Ranostay
2018-09-02 9:19 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180902101924.03f63471@archlinux \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).