* [PATCH] Revert "iio: temperature: maxim_thermocouple: add MAX31856 part"
@ 2018-08-25 9:00 Matt Ranostay
2018-09-02 9:19 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Matt Ranostay @ 2018-08-25 9:00 UTC (permalink / raw)
To: linux-iio; +Cc: jic23, Matt Ranostay
This reverts commit 535fba29b3e1afef4ba201b3c69a6992583ec0bd.
Seems the submitter (er me, hang head in shame) didn't look at the datasheet
enough to see that the registers are quite different.
This needs to be reverted because a) would never work b) to open it be added
to a Maxim RTDs (Resistance Temperature Detectors) under development by author
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
---
drivers/iio/temperature/maxim_thermocouple.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
index 54e383231d1e..c31b9633f32d 100644
--- a/drivers/iio/temperature/maxim_thermocouple.c
+++ b/drivers/iio/temperature/maxim_thermocouple.c
@@ -258,7 +258,6 @@ static int maxim_thermocouple_remove(struct spi_device *spi)
static const struct spi_device_id maxim_thermocouple_id[] = {
{"max6675", MAX6675},
{"max31855", MAX31855},
- {"max31856", MAX31855},
{},
};
MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Revert "iio: temperature: maxim_thermocouple: add MAX31856 part"
2018-08-25 9:00 [PATCH] Revert "iio: temperature: maxim_thermocouple: add MAX31856 part" Matt Ranostay
@ 2018-09-02 9:19 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-09-02 9:19 UTC (permalink / raw)
To: Matt Ranostay; +Cc: linux-iio
On Sat, 25 Aug 2018 02:00:48 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> This reverts commit 535fba29b3e1afef4ba201b3c69a6992583ec0bd.
>
> Seems the submitter (er me, hang head in shame) didn't look at the datasheet
> enough to see that the registers are quite different.
>
> This needs to be reverted because a) would never work b) to open it be added
> to a Maxim RTDs (Resistance Temperature Detectors) under development by author
>
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Applied to the fixes-to greg branch of iio.git and marked for stable
so we avoid confusing people in the future.
Jonathan
> ---
> drivers/iio/temperature/maxim_thermocouple.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
> index 54e383231d1e..c31b9633f32d 100644
> --- a/drivers/iio/temperature/maxim_thermocouple.c
> +++ b/drivers/iio/temperature/maxim_thermocouple.c
> @@ -258,7 +258,6 @@ static int maxim_thermocouple_remove(struct spi_device *spi)
> static const struct spi_device_id maxim_thermocouple_id[] = {
> {"max6675", MAX6675},
> {"max31855", MAX31855},
> - {"max31856", MAX31855},
> {},
> };
> MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-02 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-25 9:00 [PATCH] Revert "iio: temperature: maxim_thermocouple: add MAX31856 part" Matt Ranostay
2018-09-02 9:19 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).