From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 3 Sep 2018 12:20:22 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Philipp Rossak , mark.rutland@arm.com, geert+renesas@glider.be, linux-iio@vger.kernel.org, robh+dt@kernel.org, linux-sunxi@googlegroups.com, clabbe.montjoie@gmail.com, pmeerw@pmeerw.net, lee.jones@linaro.org, lars@metafoo.de, quentin.schulz@bootlin.com, linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org, arnd@arndb.de, vilhelm.gray@gmail.com, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, rdunlap@infradead.org, arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org, lukas@wunner.de, knaack.h@gmx.de, eugen.hristev@microchip.com, jic23@kernel.org Subject: Re: [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor Message-ID: <20180903102022.fkxfkxadkt4vpbmb@flea> References: <20180830154518.29507-1-embed3d@gmail.com> <20180830154518.29507-22-embed3d@gmail.com> <20180831091137.wkbbipssyd6mqfbt@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="572ywfuqjxaaxz76" In-Reply-To: List-ID: --572ywfuqjxaaxz76 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 31, 2018 at 05:51:41PM +0800, Icenowy Zheng wrote: > Personally I suggest to leave out all SID or calibration related > patches here. >=20 > Currently we seems to be wrongly converting SID to big endian, however, > the orgnization of the THS calibration data on H6 shows that it's > surely little endian: >=20 > It consists a temperature value in 1/10 celsuis as unit, and some > thermal register readout values, which are the values read out at the > given temperature, and every value here (the temperature and the > readout) are all half word length. >=20 > Let the temperature value be AABB, the two readout values be XXYY and > ZZWW, the oragnization is: > BB AA YY XX WW ZZ ** ** . >=20 > When converting the SID to big endian, it becomes: > XX YY AA BB ** ** ZZ WW , > which is non-sense, and not able to do sub-word cell addressing. >=20 > Maxime, should I drop the LE2BE conversion in SID driver? (I doubt > whether it will break compatibility.) This is exposed to the userspace, so no. Maxime >=20 --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --572ywfuqjxaaxz76 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAluNCuUACgkQ0rTAlCFN r3TJ2w//el4NVxPq4OpMbyzUfcul9GaG/NaAQItiR7kRrUtBBHzdsaOyUtn8TJd1 BWTbQRlOhE81VRZak/RPpOe1r7YTHQQehbuUgbxR7Zeys3Fx3JR+xTjGze5vXCNs 0sBgu13YW1elL8XCHTNbWfZOo8VVC9EzYOviuGPo1zkMa1w72pM58laCzMR5MoOK JimfZ/+UM/kIbY6mt8U/+0YSMG4S5STYOrScbJ5QdlRmPU3MLVl8LHwqqAYwbbV+ pP7J/B268S/GWa1jY/pDzWV/Gbq0vE+Cv8/iHFP5XesE0ixTzb1aRbC3K2vpawvC rMFVZCa6j5BS2Mx0NSwbpp9JNEmiuIfbBeu+7Eiz/6dXNGsaTFhN7vOUcKEg2TAo OsGgxFR0kgHwLOtTggBWGKEtYK6umCkKdMP+yy2RQWT6GYK91fx5e93jfQR9Vhvr 0pvmSPuXcdXHJtTyasq/tF7ZPD7rjLWkFCFQSzXDDmG9qczJEJZZ1k0oLfPi78u6 ZiRaaN5qLsp6HlnLGODI5jewkDZ9JwlzoPasrSJHlChya5KB/QbAN6fhwkLJcRJe ZEvqJxezEi+apkfMpWGhdI9D0ODGuNBuvQv+NqPLU/seQw1XJJvi0Zy2Bw9K6vnd PHRBUt/aPeR/Vr3ps4/93z3VJFcQws3dQYyxVj3J9FYy5jo4oYg= =IEeZ -----END PGP SIGNATURE----- --572ywfuqjxaaxz76--