From: Jonathan Cameron <jic23@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: YueHaibing <yuehaibing@huawei.com>,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH -next] iio: potentiometer: mcp4018: merge calls to of_match_device and of_device_get_match_data
Date: Sun, 16 Sep 2018 10:36:57 +0100 [thread overview]
Message-ID: <20180916103657.10cfb5ed@archlinux> (raw)
In-Reply-To: <9f3c9f9a-6bb4-19ba-65ad-53f7edd2af20@axentia.se>
On Sat, 15 Sep 2018 13:35:06 +0200
Peter Rosin <peda@axentia.se> wrote:
> On 2018-09-15 12:52, YueHaibing wrote:
> > Drop call to of_match_device, which is subsumed by the subsequent
> > call to of_device_get_match_data. The code becomes simpler, and a
> > temporary variable can be dropped.
> >
> > Found by coccinelle.
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Acked-by: Peter Rosin <peda@axentia.se>
Similar change already in place from Julia Lawall back in May but
looks like that just missed the last set for the merge window
after I managed to loose it and only picked up again when Peter
pointed it out in August.
However, something odd is going on as these are not currently in
next.
Ah, looks line staging-next was updated 2 days ago and last linux-next
is just before that. So I'm afraid you hit some very unfortunate
timing or this would have been there when you were looking.
Thanks,
Jonathan
>
> Cheers,
> Peter
next prev parent reply other threads:[~2018-09-16 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 10:52 [PATCH -next] iio: potentiometer: mcp4018: merge calls to of_match_device and of_device_get_match_data YueHaibing
2018-09-15 11:35 ` Peter Rosin
2018-09-16 9:36 ` Jonathan Cameron [this message]
2018-09-16 15:45 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180916103657.10cfb5ed@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=pmeerw@pmeerw.net \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).