From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:55208 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728306AbeIPS2q (ORCPT ); Sun, 16 Sep 2018 14:28:46 -0400 Date: Sun, 16 Sep 2018 14:05:46 +0100 From: Jonathan Cameron To: Matthias Kaehlcke Cc: Andy Gross , David Brown , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Douglas Anderson Subject: Re: [PATCH v3 1/3] dt-bindings: iio: vadc: Fix documentation of 'reg' Message-ID: <20180916140546.264c4310@archlinux> In-Reply-To: <20180910160301.237538-2-mka@chromium.org> References: <20180910160301.237538-1-mka@chromium.org> <20180910160301.237538-2-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Mon, 10 Sep 2018 09:02:59 -0700 Matthias Kaehlcke wrote: > The documentation of Qualcomm's SPMI PMIC voltage ADC claims that the > 'reg' property consists of two values, the SPMI address and the length > of the controller's registers. However the SPMI bus to which it is added > specifies "#size-cells = <0>;". Remove the controller register length > from the documentation of the field and the example. > > Signed-off-by: Matthias Kaehlcke > Reviewed-by: Douglas Anderson > Reviewed-by: Rob Herring I've already tidied this up and applied. It should hit linux-next tomorrow. Jonathan > --- > Changes in v3: > - fixed separator in commit message > - removed duplicate 'Signed-off-by' tag > > Changes in v2: > - none > --- > Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt > index 0fb46137f936..d0c188e5c922 100644 > --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt > @@ -13,7 +13,7 @@ VADC node: > - reg: > Usage: required > Value type: > - Definition: VADC base address and length in the SPMI PMIC register map. > + Definition: VADC base address in the SPMI PMIC register map. > > - #address-cells: > Usage: required > @@ -104,7 +104,7 @@ Example: > /* VADC node */ > pmic_vadc: vadc@3100 { > compatible = "qcom,spmi-vadc"; > - reg = <0x3100 0x100>; > + reg = <0x3100>; > interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>; > #address-cells = <1>; > #size-cells = <0>;