From: Slawomir Stepien <sst@poczta.fm>
To: linux-iio@vger.kernel.org
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org
Subject: [PATCH 1/2] staging: iio: cdc: ad7150: use pointer to shorten the line length
Date: Mon, 1 Oct 2018 21:33:05 +0200 [thread overview]
Message-ID: <20181001193305.GE24866@x220.localdomain> (raw)
In-Reply-To: <20181001193223.GD24866@x220.localdomain>
By using the pointer to channel attribute, we can now make the lines
short enough to eliminate the checkpatch.pl problem:
CHECK: Alignment should match open parenthesis
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/staging/iio/cdc/ad7150.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
index d16084d7068c..5b5b766a0405 100644
--- a/drivers/staging/iio/cdc/ad7150.c
+++ b/drivers/staging/iio/cdc/ad7150.c
@@ -102,18 +102,19 @@ static int ad7150_read_raw(struct iio_dev *indio_dev,
{
int ret;
struct ad7150_chip_info *chip = iio_priv(indio_dev);
+ const int *channel = &chan->channel;
switch (mask) {
case IIO_CHAN_INFO_RAW:
ret = i2c_smbus_read_word_data(chip->client,
- ad7150_addresses[chan->channel][0]);
+ ad7150_addresses[*channel][0]);
if (ret < 0)
return ret;
*val = swab16(ret);
return IIO_VAL_INT;
case IIO_CHAN_INFO_AVERAGE_RAW:
ret = i2c_smbus_read_word_data(chip->client,
- ad7150_addresses[chan->channel][1]);
+ ad7150_addresses[*channel][1]);
if (ret < 0)
return ret;
*val = swab16(ret);
--
2.19.0
next prev parent reply other threads:[~2018-10-02 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 19:32 [PATCH 0/2] Fix style problems in ad7150 driver Slawomir Stepien
2018-10-01 19:33 ` Slawomir Stepien [this message]
2018-10-04 15:21 ` [PATCH 1/2] staging: iio: cdc: ad7150: use pointer to shorten the line length Lars-Peter Clausen
2018-10-04 17:04 ` Slawomir Stepien
2018-10-01 19:33 ` [PATCH 2/2] staging: iio: cdc: ad7150: fix misaligned lines Slawomir Stepien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001193305.GE24866@x220.localdomain \
--to=sst@poczta.fm \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox