linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <Michael.Hennerich@analog.com>,
	<Dragos.Bogdan@analog.com>, <knaack.h@gmx.de>,
	<pmeerw@pmeerw.net>
Subject: Re: [PATCH 1/4] staging: iio: ad5933: rename ext_clk_Hz -> ext_clk_hz
Date: Sun, 7 Oct 2018 16:54:25 +0100	[thread overview]
Message-ID: <20181007165425.3854419a@archlinux> (raw)
In-Reply-To: <20181002115800.12399-1-alexandru.ardelean@analog.com>

On Tue, 2 Oct 2018 14:57:57 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> The checkpatch script doesn't like camel-case names.
> Renamed the variable.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

I did briefly wonder we had units of pounds for the ctrl value
below it ;)

Jonathan

> ---
>  drivers/staging/iio/impedance-analyzer/ad5933.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index a2370dd1e1a8..8a920f675b83 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -84,13 +84,13 @@
>  
>  /**
>   * struct ad5933_platform_data - platform specific data
> - * @ext_clk_Hz:		the external clock frequency in Hz, if not set
> + * @ext_clk_hz:		the external clock frequency in Hz, if not set
>   *			the driver uses the internal clock (16.776 MHz)
>   * @vref_mv:		the external reference voltage in millivolt
>   */
>  
>  struct ad5933_platform_data {
> -	unsigned long			ext_clk_Hz;
> +	unsigned long			ext_clk_hz;
>  	unsigned short			vref_mv;
>  };
>  
> @@ -726,8 +726,8 @@ static int ad5933_probe(struct i2c_client *client,
>  	else
>  		st->vref_mv = pdata->vref_mv;
>  
> -	if (pdata->ext_clk_Hz) {
> -		st->mclk_hz = pdata->ext_clk_Hz;
> +	if (pdata->ext_clk_hz) {
> +		st->mclk_hz = pdata->ext_clk_hz;
>  		st->ctrl_lb = AD5933_CTRL_EXT_SYSCLK;
>  	} else {
>  		st->mclk_hz = AD5933_INT_OSC_FREQ_Hz;

      parent reply	other threads:[~2018-10-07 23:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 11:57 [PATCH 1/4] staging: iio: ad5933: rename ext_clk_Hz -> ext_clk_hz Alexandru Ardelean
2018-10-02 11:57 ` [PATCH 2/4] staging: iio: ad5933: Add regulator binding for vref Alexandru Ardelean
2018-10-07 19:30   ` Jonathan Cameron
2018-10-02 11:57 ` [PATCH 3/4] staging: iio: ad5933: Use the clock framework for the external clock Alexandru Ardelean
2018-10-07 19:32   ` Jonathan Cameron
2018-10-02 11:58 ` [PATCH 4/4] staging: iio: ad5933: Add of_device_id table Alexandru Ardelean
2018-10-07 19:34   ` Jonathan Cameron
2018-10-07 15:54 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181007165425.3854419a@archlinux \
    --to=jic23@kernel.org \
    --cc=Dragos.Bogdan@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).