linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Slawomir Stepien <sst@poczta.fm>
Cc: linux-iio@vger.kernel.org, lars@metafoo.de,
	Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v2 1/2] staging: iio: cdc: ad7150: use value copy to shorten the line length
Date: Sun, 7 Oct 2018 20:07:35 +0100	[thread overview]
Message-ID: <20181007200735.1632bb19@archlinux> (raw)
In-Reply-To: <20181005080444.GB2984@x220.localdomain>

On Fri, 5 Oct 2018 10:04:44 +0200
Slawomir Stepien <sst@poczta.fm> wrote:

> By using the copy of channel attribute, we can now make the lines short
> enough to eliminate the checkpatch.pl problem:
> 
>     CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/cdc/ad7150.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index d16084d7068c..e2c70063fa0f 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -102,18 +102,19 @@ static int ad7150_read_raw(struct iio_dev *indio_dev,
>  {
>  	int ret;
>  	struct ad7150_chip_info *chip = iio_priv(indio_dev);
> +	int channel = chan->channel;
>  
>  	switch (mask) {
>  	case IIO_CHAN_INFO_RAW:
>  		ret = i2c_smbus_read_word_data(chip->client,
> -					ad7150_addresses[chan->channel][0]);
> +					       ad7150_addresses[channel][0]);
>  		if (ret < 0)
>  			return ret;
>  		*val = swab16(ret);
>  		return IIO_VAL_INT;
>  	case IIO_CHAN_INFO_AVERAGE_RAW:
>  		ret = i2c_smbus_read_word_data(chip->client,
> -					ad7150_addresses[chan->channel][1]);
> +					       ad7150_addresses[channel][1]);
>  		if (ret < 0)
>  			return ret;
>  		*val = swab16(ret);

  reply	other threads:[~2018-10-08  2:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05  8:04 [PATCH v2 0/2] Fix style problems in ad7150 driver Slawomir Stepien
2018-10-05  8:04 ` [PATCH v2 1/2] staging: iio: cdc: ad7150: use value copy to shorten the line length Slawomir Stepien
2018-10-07 19:07   ` Jonathan Cameron [this message]
2018-10-05  8:05 ` [PATCH v2 2/2] staging: iio: cdc: ad7150: fix misaligned lines Slawomir Stepien
2018-10-07 19:09   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181007200735.1632bb19@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=sst@poczta.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).