From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 11 Oct 2018 10:32:03 +0300 From: Dan Carpenter To: Slawomir Stepien Cc: Gabriel Capella , devel@driverdev.osuosl.org, Lars-Peter Clausen , Michael Hennerich , linux-iio@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Peter Meerwald-Stadler , Hartmut Knaack , Jonathan Cameron Subject: Re: [PATCH] staging: iio: adc: ad7280a: fix 2 checks Message-ID: <20181011073203.iesapekyqkma2cqa@mwanda> References: <20181006162715.GA8476@mantaray> <20181006202542.GC5035@x220.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20181006202542.GC5035@x220.localdomain> List-ID: On Sat, Oct 06, 2018 at 10:25:42PM +0200, Slawomir Stepien wrote: > On paź 06, 2018 13:27, Gabriel Capella wrote: > > This patch does not change the logic, it only > > corrects the checkpatch checks. > > > > The patch fixes 2 checks of type: > > "CHECK: spaces preferred around that '-'" > > I've made the same mistake few days ago. This change is incorrect. > Please see: https://lore.kernel.org/patchwork/patch/635994/. > You could add a comment. /* do not put spaces around the hyphen. #checkpatch.pl */ These are the only places which use this style and a lot of people bump into it. regards, dan carpenter