From: Slawomir Stepien <sst@poczta.fm>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: potentiometer: tpl0102: add IIO_AVAIL_RANGE support
Date: Wed, 24 Oct 2018 19:32:43 +0200 [thread overview]
Message-ID: <20181024173243.GB10909@x220.localdomain> (raw)
In-Reply-To: <20181024103858.28201-3-matt.ranostay@konsulko.com>
On paź 24, 2018 11:38, Matt Ranostay wrote:
> Report back the step range of the respective potentiometers that are
> possible back to userspace.
The many "back" in that sentence don't you think? ;)
Maybe: "Report the possible step range of the respective potentiometers back to
userspace."
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
> ---
> drivers/iio/potentiometer/tpl0102.c | 33 +++++++++++++++++++++++------
> 1 file changed, 26 insertions(+), 7 deletions(-)
The rest looks good to me
Reviewed-by: Slawomir Stepien <sst@poczta.fm>
--
Slawomir Stepien
next prev parent reply other threads:[~2018-10-25 2:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 10:38 [PATCH 0/2] iio: potentiometer: tpl0102: improve driver to report steps/range Matt Ranostay
2018-10-24 10:38 ` [PATCH 1/2] iio: potentiometer: tpl0102: switch to using pointer to chip config Matt Ranostay
2018-10-24 17:30 ` Slawomir Stepien
2018-10-28 15:44 ` Jonathan Cameron
2018-10-24 10:38 ` [PATCH 2/2] iio: potentiometer: tpl0102: add IIO_AVAIL_RANGE support Matt Ranostay
2018-10-24 17:32 ` Slawomir Stepien [this message]
2018-10-28 15:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024173243.GB10909@x220.localdomain \
--to=sst@poczta.fm \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox