From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com ([209.85.214.196]:37369 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729035AbeKPAdR (ORCPT ); Thu, 15 Nov 2018 19:33:17 -0500 Date: Thu, 15 Nov 2018 19:55:06 +0530 From: Nishad Kamdar To: "Ardelean, Alexandru" Cc: "jic23@kernel.org" , "linux-kernel@vger.kernel.org" , "lars@metafoo.de" , "knaack.h@gmx.de" , "Hennerich, Michael" , "linux-iio@vger.kernel.org" , "devel@driverdev.osuosl.org" , "pmeerw@pmeerw.net" , "gregkh@linuxfoundation.org" Subject: Re: [PATCH v4 4/4] staging: iio: ad7816: Add device tree table. Message-ID: <20181115142504.GA4098@nishad> References: <4abed67ee07c763151a76cf9e687b6edc6ced5c6.camel@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4abed67ee07c763151a76cf9e687b6edc6ced5c6.camel@analog.com> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Thu, Nov 15, 2018 at 08:16:03AM +0000, Ardelean, Alexandru wrote: > On Wed, 2018-11-14 at 23:16 +0530, Nishad Kamdar wrote: > > Add device tree table for matching vendor ID. > > > > This could have been just one patch. > Something like > [PATCH v4] staging: iio: ad7816: Add device tree table. > > It's no longer a series, because the other patches were applied already. > > I don't think you need to re-spin this [it's up to Jonathan though]. > > It's just something to keep in mind for later when re-spinning patches or > series of patches. > > Alex > Ok. I'll keep that in mind. Thanks for the review. Regards, Nishad > > Signed-off-by: Nishad Kamdar > > --- > > drivers/staging/iio/adc/ad7816.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/staging/iio/adc/ad7816.c > > b/drivers/staging/iio/adc/ad7816.c > > index a2fead85cd46..925f7086bc07 100644 > > --- a/drivers/staging/iio/adc/ad7816.c > > +++ b/drivers/staging/iio/adc/ad7816.c > > @@ -422,6 +422,14 @@ static int ad7816_probe(struct spi_device *spi_dev) > > return 0; > > } > > > > +static const struct of_device_id ad7816_of_match[] = { > > + { .compatible = "adi,ad7816", }, > > + { .compatible = "adi,ad7817", }, > > + { .compatible = "adi,ad7818", }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, ad7816_of_match); > > + > > static const struct spi_device_id ad7816_id[] = { > > { "ad7816", ID_AD7816 }, > > { "ad7817", ID_AD7817 }, > > @@ -434,6 +442,7 @@ MODULE_DEVICE_TABLE(spi, ad7816_id); > > static struct spi_driver ad7816_driver = { > > .driver = { > > .name = "ad7816", > > + .of_match_table = of_match_ptr(ad7816_of_match), > > }, > > .probe = ad7816_probe, > > .id_table = ad7816_id,