From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Stefan Popa <stefan.popa@analog.com>,
mark.rutland@arm.com, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, Michael.Hennerich@analog.com,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] dt-bindings: iio: adc: Add common ADCs properties to a separate file
Date: Sat, 17 Nov 2018 16:32:28 +0000 [thread overview]
Message-ID: <20181117163228.5f5b5bb8@archlinux> (raw)
In-Reply-To: <20181116225302.GA23266@bogus>
On Fri, 16 Nov 2018 16:53:02 -0600
Rob Herring <robh@kernel.org> wrote:
> On Fri, Nov 16, 2018 at 06:38:38PM +0000, Jonathan Cameron wrote:
> > On Tue, 13 Nov 2018 13:21:01 +0200
> > Stefan Popa <stefan.popa@analog.com> wrote:
> >
> > > There are several ADC drivers that depend on the same device tree
> > > bindings. Rather than continue to duplicate the properties, this patch
> > > adds a common adc binding document that can be referenced. For beginning,
> > > only two properties are documented.
> > >
> > > Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> > Looks very sensible to me, but as we are looking at a some generalization
> > here, I'd like an Ack from Rob if possible (as he suggested it I think :)
>
> Looks fine to me, but I don't have any clue if this will be flexible
> enough for various h/w.
I think we'll need more to cover all cases, but hopefully things that
make sense to be optional in general. Rather hard to predict. This is
the obvious stuff so far.
This is better than the current mess of different options!
Jonathan
>
> Rob
>
next prev parent reply other threads:[~2018-11-18 2:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 11:21 [PATCH v5 2/4] dt-bindings: iio: adc: Add common ADCs properties to a separate file Stefan Popa
2018-11-16 18:38 ` Jonathan Cameron
2018-11-16 22:53 ` Rob Herring
2018-11-17 16:32 ` Jonathan Cameron [this message]
2018-11-16 22:53 ` Rob Herring
2018-11-17 16:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181117163228.5f5b5bb8@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).