From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:45704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726859AbeKYUAM (ORCPT ); Sun, 25 Nov 2018 15:00:12 -0500 Date: Sun, 25 Nov 2018 09:09:30 +0000 From: Jonathan Cameron To: Stephan Gerhold Cc: linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Srinivas Pandruvada Subject: Re: [PATCH] iio: accel: kxcjk-1013: Add the "KXJ2109" ACPI HID Message-ID: <20181125090930.0086a021@archlinux> In-Reply-To: <20181124162220.8523-1-stephan@gerhold.net> References: <20181124162220.8523-1-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Sat, 24 Nov 2018 17:22:20 +0100 Stephan Gerhold wrote: > This HID is used on the ASUS MeMO Pad 7 (ME176C) tablet. > > Signed-off-by: Stephan Gerhold Other than a distinct temptation to rant about formats of ACPI IDs (4 characters the a number), looks good. For reference (I was waiting for a build so decided to dig it out ;) ACPI 6.2 spec. 6.5.1 "A valid ACPI ID must be of the form "NNNN####" where N is an uppercase letter or a digit ('0'-'9') and # is a hex digit." is the text about a manufacturer defined ID. If anyone has a contact at ASUS who I can rant at do pass it on! Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/accel/kxcjk-1013.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c > index af53a1084ee5..cc5b2beb1328 100644 > --- a/drivers/iio/accel/kxcjk-1013.c > +++ b/drivers/iio/accel/kxcjk-1013.c > @@ -1491,6 +1491,7 @@ static const struct acpi_device_id kx_acpi_match[] = { > {"KXCJ9000", KXCJ91008}, > {"KIOX000A", KXCJ91008}, > {"KXTJ1009", KXTJ21009}, > + {"KXJ2109", KXTJ21009}, > {"SMO8500", KXCJ91008}, > { }, > };