From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 28 Nov 2018 09:07:26 +0000 From: Lee Jones To: Vignesh R Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mfd: ti_am335x_tscadc: Provide unique name for child mfd cells Message-ID: <20181128090726.GS4272@dell> References: <20181119064236.28902-1-vigneshr@ti.com> <20181119064236.28902-2-vigneshr@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20181119064236.28902-2-vigneshr@ti.com> List-ID: On Mon, 19 Nov 2018, Vignesh R wrote: > Provide unique names for child mfd cells, this is required in order to > support registering of multiple instances of same ti_am335x_tscadc IP. I don't think it is. What is the error you are receiving? > Signed-off-by: Vignesh R > --- > drivers/mfd/ti_am335x_tscadc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > index c2d47d78705b..ee08af34f81d 100644 > --- a/drivers/mfd/ti_am335x_tscadc.c > +++ b/drivers/mfd/ti_am335x_tscadc.c > @@ -248,7 +248,8 @@ static int ti_tscadc_probe(struct platform_device *pdev) > if (tsc_wires > 0) { > tscadc->tsc_cell = tscadc->used_cells; > cell = &tscadc->cells[tscadc->used_cells++]; > - cell->name = "TI-am335x-tsc"; > + cell->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s:%s", > + dev_name(&pdev->dev), "tsc"); > cell->of_compatible = "ti,am3359-tsc"; > cell->platform_data = &tscadc; > cell->pdata_size = sizeof(tscadc); > @@ -258,7 +259,8 @@ static int ti_tscadc_probe(struct platform_device *pdev) > if (adc_channels > 0) { > tscadc->adc_cell = tscadc->used_cells; > cell = &tscadc->cells[tscadc->used_cells++]; > - cell->name = "TI-am335x-adc"; > + cell->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s:%s", > + dev_name(&pdev->dev), "adc"); > cell->of_compatible = "ti,am3359-adc"; > cell->platform_data = &tscadc; > cell->pdata_size = sizeof(tscadc); -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog