Re: [PATCH] staging: iio: ad7816: drop unnecessary initialization of variables

Jonathan Cameron
2018-12-16T12:38:11Z

On Wed, 12 Dec 2018 23:27:07 +0530
Hardik Singh Rathore <hardiksingh.k@gmail.com> wrote:

> Initialization is unnecessary when the variable is written before it is
> read. There were some occasions in which the driver would initialize `ret'
> during declaration without need.
>
> Signed-off-by: Hardik Singh Rathore <hardiksingh.k@gmail.com>
Applied.

Thanks,

Jonathan
> ---
> drivers/staging/iio/adc/ad7816.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
> index 5209651a1b25..ee50e7296795 100644
> --- a/drivers/staging/iio/adc/ad7816.c
> +++ b/drivers/staging/iio/adc/ad7816.c
> @@ -65,7 +65,7 @@ enum ad7816_type {
> static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data)
> {
> struct spi_device *spi_dev = chip->spi_dev;
> - int ret = 0;
> + int ret;
> __be16 buf;
>
> gpiod_set_value(chip->rdwr_pin, 1);
> @@ -106,7 +106,7 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data)
> static int ad7816_spi_write(struct ad7816_chip_info *chip, u8 data)
> {
> struct spi_device *spi_dev = chip->spi_dev;
> - int ret = 0;
> + int ret;
>
> gpiod_set_value(chip->rdwr_pin, 1);
> gpiod_set_value(chip->rdwr_pin, 0);
> @@ -354,8 +354,7 @@ static int ad7816_probe(struct spi_device *spi_dev)
> {
> struct ad7816_chip_info *chip;
> struct iio_dev *indio_dev;
> - int ret = 0;
> - int i;
> + int i, ret;
>
> indio_dev = devm_iio_device_alloc(&spi_dev->dev, sizeof(*chip));
> if (!indio_dev)