From: Jonathan Cameron <jic23@kernel.org>
To: Martin Kelly <martin@martingkelly.com>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Daniel Baluta <daniel.baluta@gmail.com>
Subject: Re: [PATCH 1/5] iio:bmi160: add SPDX identifiers
Date: Sat, 19 Jan 2019 17:03:05 +0000 [thread overview]
Message-ID: <20190119170305.7b391c55@archlinux> (raw)
In-Reply-To: <20190114035621.5252-2-martin@martingkelly.com>
On Sun, 13 Jan 2019 19:56:17 -0800
Martin Kelly <martin@martingkelly.com> wrote:
> From: Martin Kelly <martin@martingkelly.com>
>
> Add SPDX identifiers (GPL 2) for the BMI160 driver. bmi160.h had an
> identifier, but the other files did not.
>
> Signed-off-by: Martin Kelly <martin@martingkelly.com>
This is fine, but for anything (even SPDX) that touches licenses
I ideally like to get an Ack from the main author.
cc'd Daniel.
> ---
> drivers/iio/imu/bmi160/bmi160_core.c | 5 +----
> drivers/iio/imu/bmi160/bmi160_i2c.c | 5 +----
> drivers/iio/imu/bmi160/bmi160_spi.c | 4 +---
> 3 files changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
> index b10330b0f93f..ce61026d84c3 100644
> --- a/drivers/iio/imu/bmi160/bmi160_core.c
> +++ b/drivers/iio/imu/bmi160/bmi160_core.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * BMI160 - Bosch IMU (accel, gyro plus external magnetometer)
> *
> * Copyright (c) 2016, Intel Corporation.
> *
> - * This file is subject to the terms and conditions of version 2 of
> - * the GNU General Public License. See the file COPYING in the main
> - * directory of this archive for more details.
> - *
> * IIO core driver for BMI160, with support for I2C/SPI busses
> *
> * TODO: magnetometer, interrupts, hardware FIFO
> diff --git a/drivers/iio/imu/bmi160/bmi160_i2c.c b/drivers/iio/imu/bmi160/bmi160_i2c.c
> index 5b1f7e6af651..e36f5e82d400 100644
> --- a/drivers/iio/imu/bmi160/bmi160_i2c.c
> +++ b/drivers/iio/imu/bmi160/bmi160_i2c.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * BMI160 - Bosch IMU, I2C bits
> *
> * Copyright (c) 2016, Intel Corporation.
> *
> - * This file is subject to the terms and conditions of version 2 of
> - * the GNU General Public License. See the file COPYING in the main
> - * directory of this archive for more details.
> - *
> * 7-bit I2C slave address is:
> * - 0x68 if SDO is pulled to GND
> * - 0x69 if SDO is pulled to VDDIO
> diff --git a/drivers/iio/imu/bmi160/bmi160_spi.c b/drivers/iio/imu/bmi160/bmi160_spi.c
> index e521ad14eeac..c19e3df35559 100644
> --- a/drivers/iio/imu/bmi160/bmi160_spi.c
> +++ b/drivers/iio/imu/bmi160/bmi160_spi.c
> @@ -1,11 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * BMI160 - Bosch IMU, SPI bits
> *
> * Copyright (c) 2016, Intel Corporation.
> *
> - * This file is subject to the terms and conditions of version 2 of
> - * the GNU General Public License. See the file COPYING in the main
> - * directory of this archive for more details.
> */
> #include <linux/acpi.h>
> #include <linux/module.h>
next prev parent reply other threads:[~2019-01-19 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 3:56 [PATCH 0/5] iio:bmi160: add drdy interrupt support Martin Kelly
2019-01-14 3:56 ` [PATCH 1/5] iio:bmi160: add SPDX identifiers Martin Kelly
2019-01-19 17:03 ` Jonathan Cameron [this message]
2019-01-14 3:56 ` [PATCH 2/5] iio:bmi160: add drdy interrupt support Martin Kelly
2019-01-19 17:17 ` Jonathan Cameron
2019-01-22 2:06 ` Martin Kelly
2019-01-14 3:56 ` [PATCH 3/5] dt-bindings: fix incorrect bmi160 IRQ note Martin Kelly
2019-01-14 3:56 ` [PATCH 4/5] dt-bindings:bmi160: add "BOTH" int pin type Martin Kelly
2019-01-19 17:24 ` Jonathan Cameron
2019-01-14 3:56 ` [PATCH 5/5] iio:bmi160:snap timestamp closer to event Martin Kelly
2019-01-19 17:29 ` Jonathan Cameron
2019-01-15 2:13 ` [PATCH 0/5] iio:bmi160: add drdy interrupt support Martin Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119170305.7b391c55@archlinux \
--to=jic23@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=martin@martingkelly.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox