Re: [PATCH] iio:chemical:sps30 Suppress some switch fallthrough warnings.

[Tomasz Duszynski <tduszyns@gmail.com>]

On Sat, Feb 09, 2019 at 07:39:34PM +0000, Jonathan Cameron wrote:
> Fixes warnings reported on linux-next but marking one path
> and adding an explicit return in the other.
>

Looks good.

Acked-by: Tomasz Duszynski <tduszyns@gmail.com>

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Andreas Brauchli <a.brauchli@elementarea.net>
> ---
> I'd like to get this one into linux-next fairly quick so it anyone
> has time to do a quick sanity check it would be much appreciated!
>
>  drivers/iio/chemical/sps30.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/chemical/sps30.c b/drivers/iio/chemical/sps30.c
> index 375df5060ed5..edbb956e81e8 100644
> --- a/drivers/iio/chemical/sps30.c
> +++ b/drivers/iio/chemical/sps30.c
> @@ -118,6 +118,7 @@ static int sps30_do_cmd(struct sps30_state *state, u16 cmd, u8 *data, int size)
>  	case SPS30_READ_AUTO_CLEANING_PERIOD:
>  		buf[0] = SPS30_AUTO_CLEANING_PERIOD >> 8;
>  		buf[1] = (u8)SPS30_AUTO_CLEANING_PERIOD;
> +		/* fall through */
>  	case SPS30_READ_DATA_READY_FLAG:
>  	case SPS30_READ_DATA:
>  	case SPS30_READ_SERIAL:
> @@ -295,6 +296,8 @@ static int sps30_read_raw(struct iio_dev *indio_dev,
>  				*val2 = 10000;
>
>  				return IIO_VAL_INT_PLUS_MICRO;
> +			default:
> +				return -EINVAL;
>  			}
>  		default:
>  			return -EINVAL;
> --
> 2.20.1
>