From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21F00C43381 for ; Wed, 20 Feb 2019 10:46:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E050B2147A for ; Wed, 20 Feb 2019 10:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550659571; bh=cQuaSlrFfLIcxlXlGRVwlfXeHX/mDog3QJoG8dYhq9c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=rM2hqSNOOyeeqM+O8wLNtuCp7vJR7gIUoz66Ojal6VXOPK16K97WwVDweq2Gbx6p0 smtbufslfGgb6SHXTLp+8TW35NXC53J4fxWiZuf8YX5ZxBrznZnZ7OBmKNpv556nGU ceYv5n+F0Zb5p2Ur+3J2wwmO1nz+szKai14QLsE4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbfBTKqK (ORCPT ); Wed, 20 Feb 2019 05:46:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:59308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726209AbfBTKqK (ORCPT ); Wed, 20 Feb 2019 05:46:10 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 44A6F20C01; Wed, 20 Feb 2019 10:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550659569; bh=cQuaSlrFfLIcxlXlGRVwlfXeHX/mDog3QJoG8dYhq9c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qkgHR6AlmOtbRQptS60B/GiScZwODRkQHRoHnWln7LBhu+jxMa9+9ceLsIbS38hj+ O8Fl7ehEMstbsLg2tf/EOA83WbgRwY0FZsQxOkIh24ByWWAnUa3QT+pdCDgX3td/iO bY1ik25g4N5gEzFL4sv4G92w4G9dAtya9DAlZPiQ= Date: Wed, 20 Feb 2019 10:46:03 +0000 From: Jonathan Cameron To: Stefan Popa Cc: , , , , , , , , devicetree@vger.kernel.org Subject: Re: [PATCH 6/6] iio: imu: adis16480: Add docs for ADIS16480 IMU Message-ID: <20190220104603.15053787@archlinux> In-Reply-To: <1550596338-24220-7-git-send-email-stefan.popa@analog.com> References: <1550596338-24220-1-git-send-email-stefan.popa@analog.com> <1550596338-24220-7-git-send-email-stefan.popa@analog.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 19 Feb 2019 19:12:18 +0200 Stefan Popa wrote: > Document support for ADIS16480 Inertial Measurement Unit. > > Signed-off-by: Stefan Popa Make sure to CC the dt list as well as Rob. Just because it's normally Rob who is kind enough to review our patches, doesn't mean we shouldn't bombard any other interested parties with them as well ;) Looks good to me, with the exception of the DIO1 vs 2 default discussed in the earlier patch. Thanks, Jonathan > --- > .../devicetree/bindings/iio/imu/adi,adis16480.txt | 49 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16480.txt > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16480.txt b/Documentation/devicetree/bindings/iio/imu/adi,adis16480.txt > new file mode 100644 > index 0000000..dacf5f7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16480.txt > @@ -0,0 +1,49 @@ > + > +Analog Devices ADIS16480 and similar IMUs > + > +Required properties for the ADIS16480: > + > +- compatible: Must be one of > + * "adi,adis16375" > + * "adi,adis16480" > + * "adi,adis16485" > + * "adi,adis16488" > + * "adi,adis16495-1" > + * "adi,adis16495-2" > + * "adi,adis16495-3" > + * "adi,adis16497-1" > + * "adi,adis16497-2" > + * "adi,adis16497-3" > +- reg: SPI chip select number for the device > +- spi-max-frequency: Max SPI frequency to use > + see: Documentation/devicetree/bindings/spi/spi-bus.txt > +- spi-cpha: See Documentation/devicetree/bindings/spi/spi-bus.txt > +- spi-cpol: See Documentation/devicetree/bindings/spi/spi-bus.txt > +- interrupts: interrupt mapping for IRQ, accepted values are: > + * IRQF_TRIGGER_RISING > + * IRQF_TRIGGER_FALLING > + > +Optional properties: > + > +- interrupt-names: Data ready line selection. Valid values are: > + * DIO1 > + * DIO2 > + * DIO3 > + * DIO4 > + If this field is left empty, the factory default assigns DIO2 as data > + ready signal. > +- reset-gpios: must be the device tree identifier of the RESET pin. As the line > + is active low, it should be marked GPIO_ACTIVE_LOW. > + > +Example: > + > + imu@0 { > + compatible = "adi,adis16495-1"; > + reg = <0>; > + spi-max-frequency = <3200000>; > + spi-cpol; > + spi-cpha; > + interrupts = <25 IRQF_TRIGGER_FALLING>; > + interrupt-parent = <&gpio>; > + interrupt-names = "DIO2"; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index e4091ac..beecd1e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -942,6 +942,7 @@ F: drivers/dma/dma-axi-dmac.c > ANALOG DEVICES INC IIO DRIVERS > M: Lars-Peter Clausen > M: Michael Hennerich > +M: Stefan Popa > W: http://wiki.analog.com/ > W: http://ez.analog.com/community/linux-device-drivers > S: Supported