* [PATCH -next] iio: adc: ingenic: remove redundant dev_err call in ingenic_adc_probe()
@ 2019-02-18 6:57 Wei Yongjun
2019-02-20 10:51 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2019-02-18 6:57 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Artur Rojek
Cc: Wei Yongjun, linux-iio, kernel-janitors
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/iio/adc/ingenic-adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-adc.c
index 6ee1673deb0d..8f9c125939a8 100644
--- a/drivers/iio/adc/ingenic-adc.c
+++ b/drivers/iio/adc/ingenic-adc.c
@@ -302,10 +302,8 @@ static int ingenic_adc_probe(struct platform_device *pdev)
mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
adc->base = devm_ioremap_resource(dev, mem_base);
- if (IS_ERR(adc->base)) {
- dev_err(dev, "Unable to ioremap mmio resource\n");
+ if (IS_ERR(adc->base))
return PTR_ERR(adc->base);
- }
adc->clk = devm_clk_get(dev, "adc");
if (IS_ERR(adc->clk)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] iio: adc: ingenic: remove redundant dev_err call in ingenic_adc_probe()
2019-02-18 6:57 [PATCH -next] iio: adc: ingenic: remove redundant dev_err call in ingenic_adc_probe() Wei Yongjun
@ 2019-02-20 10:51 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-02-20 10:51 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Artur Rojek, linux-iio, kernel-janitors
On Mon, 18 Feb 2019 06:57:35 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Hi
The patch is good, but the fixes tag is too strong. We don't want
the noise of backporting the dropping of an overly verbose bit
of error printing. It's not doing any harm, just not doing any
good either! So, let us keep this as low priority tidy up.
Applied to the togreg branch of iio.git with that tag dropped.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ingenic-adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-adc.c
> index 6ee1673deb0d..8f9c125939a8 100644
> --- a/drivers/iio/adc/ingenic-adc.c
> +++ b/drivers/iio/adc/ingenic-adc.c
> @@ -302,10 +302,8 @@ static int ingenic_adc_probe(struct platform_device *pdev)
>
> mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> adc->base = devm_ioremap_resource(dev, mem_base);
> - if (IS_ERR(adc->base)) {
> - dev_err(dev, "Unable to ioremap mmio resource\n");
> + if (IS_ERR(adc->base))
> return PTR_ERR(adc->base);
> - }
>
> adc->clk = devm_clk_get(dev, "adc");
> if (IS_ERR(adc->clk)) {
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-20 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-18 6:57 [PATCH -next] iio: adc: ingenic: remove redundant dev_err call in ingenic_adc_probe() Wei Yongjun
2019-02-20 10:51 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).