* [PATCH] Staging: iio: meter: fixed typo
@ 2019-02-13 10:19 Leonard Pollak
2019-02-13 10:25 ` Hennerich, Michael
0 siblings, 1 reply; 3+ messages in thread
From: Leonard Pollak @ 2019-02-13 10:19 UTC (permalink / raw)
To: jic23, lars, pmeerw, Michael.hennerich; +Cc: linux-iio, Leonard Pollak
This patch fixes an obvious typo, which will cause erroneously returning the Peak
Voltage instead of the Peak Current.
Signed-off-by: Leonard Pollak <leonardp@tr-host.de>
---
drivers/staging/iio/meter/ade7854.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c
index 029c3bf42d4d..07774c000c5a 100644
--- a/drivers/staging/iio/meter/ade7854.c
+++ b/drivers/staging/iio/meter/ade7854.c
@@ -269,7 +269,7 @@ static IIO_DEV_ATTR_VPEAK(0644,
static IIO_DEV_ATTR_IPEAK(0644,
ade7854_read_32bit,
ade7854_write_32bit,
- ADE7854_VPEAK);
+ ADE7854_IPEAK);
static IIO_DEV_ATTR_APHCAL(0644,
ade7854_read_16bit,
ade7854_write_16bit,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] Staging: iio: meter: fixed typo
2019-02-13 10:19 [PATCH] Staging: iio: meter: fixed typo Leonard Pollak
@ 2019-02-13 10:25 ` Hennerich, Michael
2019-02-20 11:39 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Hennerich, Michael @ 2019-02-13 10:25 UTC (permalink / raw)
To: Leonard Pollak, jic23@kernel.org, lars@metafoo.de,
pmeerw@pmeerw.net
Cc: linux-iio@vger.kernel.org
> -----Original Message-----
> From: leonard.pollak@tr-host.de [mailto:leonard.pollak@tr-host.de] On Behalf Of Leonard Pollak
> Sent: Mittwoch, 13. Februar 2019 11:20
> To: jic23@kernel.org; lars@metafoo.de; pmeerw@pmeerw.net; Hennerich, Michael <Michael.Hennerich@analog.com>
> Cc: linux-iio@vger.kernel.org; Leonard Pollak <leonardp@tr-host.de>
> Subject: [PATCH] Staging: iio: meter: fixed typo
>
> This patch fixes an obvious typo, which will cause erroneously returning the Peak
> Voltage instead of the Peak Current.
>
> Signed-off-by: Leonard Pollak <leonardp@tr-host.de>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/staging/iio/meter/ade7854.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c
> index 029c3bf42d4d..07774c000c5a 100644
> --- a/drivers/staging/iio/meter/ade7854.c
> +++ b/drivers/staging/iio/meter/ade7854.c
> @@ -269,7 +269,7 @@ static IIO_DEV_ATTR_VPEAK(0644,
> static IIO_DEV_ATTR_IPEAK(0644,
> ade7854_read_32bit,
> ade7854_write_32bit,
> - ADE7854_VPEAK);
> + ADE7854_IPEAK);
> static IIO_DEV_ATTR_APHCAL(0644,
> ade7854_read_16bit,
> ade7854_write_16bit,
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: iio: meter: fixed typo
2019-02-13 10:25 ` Hennerich, Michael
@ 2019-02-20 11:39 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-02-20 11:39 UTC (permalink / raw)
To: Hennerich, Michael
Cc: Leonard Pollak, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org
On Wed, 13 Feb 2019 10:25:18 +0000
"Hennerich, Michael" <Michael.Hennerich@analog.com> wrote:
> > -----Original Message-----
> > From: leonard.pollak@tr-host.de [mailto:leonard.pollak@tr-host.de] On Behalf Of Leonard Pollak
> > Sent: Mittwoch, 13. Februar 2019 11:20
> > To: jic23@kernel.org; lars@metafoo.de; pmeerw@pmeerw.net; Hennerich, Michael <Michael.Hennerich@analog.com>
> > Cc: linux-iio@vger.kernel.org; Leonard Pollak <leonardp@tr-host.de>
> > Subject: [PATCH] Staging: iio: meter: fixed typo
> >
> > This patch fixes an obvious typo, which will cause erroneously returning the Peak
> > Voltage instead of the Peak Current.
> >
> > Signed-off-by: Leonard Pollak <leonardp@tr-host.de>
>
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Applied to the fixes-togreg branch of iio.git, marked for stable.
Will probably not go upstream until after the coming merge window.
It's been broken a 'while' so I'm not going to rush it in.
Thanks,
Jonathan
>
> > ---
> > drivers/staging/iio/meter/ade7854.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c
> > index 029c3bf42d4d..07774c000c5a 100644
> > --- a/drivers/staging/iio/meter/ade7854.c
> > +++ b/drivers/staging/iio/meter/ade7854.c
> > @@ -269,7 +269,7 @@ static IIO_DEV_ATTR_VPEAK(0644,
> > static IIO_DEV_ATTR_IPEAK(0644,
> > ade7854_read_32bit,
> > ade7854_write_32bit,
> > - ADE7854_VPEAK);
> > + ADE7854_IPEAK);
> > static IIO_DEV_ATTR_APHCAL(0644,
> > ade7854_read_16bit,
> > ade7854_write_16bit,
> > --
> > 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-20 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-13 10:19 [PATCH] Staging: iio: meter: fixed typo Leonard Pollak
2019-02-13 10:25 ` Hennerich, Michael
2019-02-20 11:39 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).