From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472D6C43381 for ; Wed, 20 Feb 2019 16:13:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F8B72086A for ; Wed, 20 Feb 2019 16:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725915AbfBTQNJ (ORCPT ); Wed, 20 Feb 2019 11:13:09 -0500 Received: from mga05.intel.com ([192.55.52.43]:37889 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfBTQNJ (ORCPT ); Wed, 20 Feb 2019 11:13:09 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 08:13:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,391,1544515200"; d="scan'208";a="276512460" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga004.jf.intel.com with ESMTP; 20 Feb 2019 08:13:05 -0800 Received: from andy by smile with local (Exim 4.92-RC6) (envelope-from ) id 1gwUUZ-0005no-Ek; Wed, 20 Feb 2019 18:13:03 +0200 Date: Wed, 20 Feb 2019 18:13:03 +0200 From: Andy Shevchenko To: "H. Nikolaus Schaller" Cc: Linus Walleij , Jonathan Cameron , Rob Herring , Mark Rutland , Charles Keepax , Song Qiang , letux-kernel@openphoenux.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/9] iio mount matrix - revitalize missing bindings documentation and provide code for bmc150, bmg160, bma180, itg3200, hmc584x Message-ID: <20190220161303.GY9224@smile.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, Feb 20, 2019 at 03:00:47PM +0100, H. Nikolaus Schaller wrote: > This patch series adds the mount-matrix to several iio sensor drivers > used in handheld devices. > > The mount-matrix translates the quite arbitrary orientation of the sensor > on some printed circuit board to user-tangible orientation in handheld > devices that relates to typical screen orientation. > > There was a bindings documentation by Linus Walleij but the patch > did not make it into mainline. Therefore I resend it here. > > Next I have added some clarifications (at least I hope it clarifies) > in a second patch. > > Finally, the patch set implements the hooks for the mount matrix > in several iio drivers: bmc150, bma180, bmg160, itg3200, hmc5843. > This includes also one patch for the bma180 to convert it to devm API. > > We use them in different variants of the omap3-gta04 so a separate > patch set will provide device tree additions for them. Thanks for the patch, overall good stuff there. Couple of things, though: - address my comments (consider them against entire series) - check my patch I sent today to support this from ACPI I wouldn't like to spread more drivers use specific of_foo_bar stuff where it's easily to support everything (note: device_property_* calls supports software fw nodes as well). Perhaps, you may incorporate my patch into your nice series. > > > H. Nikolaus Schaller (8): > iio: bindings: clarifications for mount-matrix bindings > iio: accel: bmc150: add mount matrix support > iio: accel: bma180: add mount matrix support > iio: accel: bma180: convert to devm > iio: gyro: bmg160: add mount matrix support > iio: gyro: itg3200: add mount matrix support > iio: magnetometer: bmc150: add mount matrix support > iio: magnetometer: hmc5843: add mount matrix support > > Linus Walleij (1): > iio: document bindings for mounting matrices > > .../devicetree/bindings/iio/mount-matrix.txt | 162 ++++++++++++++++++ > drivers/iio/accel/bma180.c | 70 ++++---- > drivers/iio/accel/bmc150-accel-core.c | 19 ++ > drivers/iio/gyro/bmg160_core.c | 19 ++ > drivers/iio/gyro/itg3200_core.c | 18 ++ > drivers/iio/magnetometer/bmc150_magn.c | 19 ++ > drivers/iio/magnetometer/hmc5843.h | 1 + > drivers/iio/magnetometer/hmc5843_core.c | 14 ++ > include/linux/iio/gyro/itg3200.h | 1 + > 9 files changed, 288 insertions(+), 35 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/mount-matrix.txt > > -- > 2.19.1 > -- With Best Regards, Andy Shevchenko