From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C182C43381 for ; Sat, 2 Mar 2019 19:13:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEFC320863 for ; Sat, 2 Mar 2019 19:13:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551554004; bh=GObx0U9gj8jbLanj4fBAPBVzx8McevuGZQWJBOpRJ/Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=mXVX14ApC8vArkbhvDwQcqpSZGMuaSC/w27PAiIsmdS2YmoHoA7cxy/ubVNCoAbzM sbYLtu5UGEsiD/T9TsaOOfUBxrrnaAfdCdtCwUnpQonRNelrQyGal/zMm5NGH06SPy Z9e6G3ip/GY1ocFONAFy3P2u/ol10CJwq/i2Msvo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbfCBTNY (ORCPT ); Sat, 2 Mar 2019 14:13:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:35530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726434AbfCBTNY (ORCPT ); Sat, 2 Mar 2019 14:13:24 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE29F20838; Sat, 2 Mar 2019 19:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551554003; bh=GObx0U9gj8jbLanj4fBAPBVzx8McevuGZQWJBOpRJ/Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=poLtuuNIZCGtU7P+EUp9Iw5MjsKeKqj+jhMzOG++2YTfZO4Fqr93/EUU9PM4LCfQq NvmXT+0bVxOxT3V/kJEFCHk2w2h50rGDdo/2VLSrLoL535Y6j2zg+q9pymfEgCkVj1 LzqlgwCoizpNR55A0lnb/sFI3zDizc3KKpgnpo5E= Date: Sat, 2 Mar 2019 19:13:16 +0000 From: Jonathan Cameron To: Renato Lui Geh Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, stefan.popa@analog.com, alexandru.Ardelean@analog.com, giuliano.belinassi@usp.br, robh+dt@kernel.org, mark.rutland@arm.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, devicetree@vger.kernel.org Subject: Re: [PATCH v4 9/9] staging: iio: ad7780: add device tree binding Message-ID: <20190302191316.66c4e05d@archlinux> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 28 Feb 2019 11:26:28 -0300 Renato Lui Geh wrote: > Adds a device tree binding for the ad7780 driver. > > Signed-off-by: Renato Lui Geh Looks good to me, but we'll see if Rob picks up on things I've missed. Jonathan > --- > .../bindings/iio/adc/adi,ad7780.txt | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt > new file mode 100644 > index 000000000000..440e52555349 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt > @@ -0,0 +1,48 @@ > +* Analog Devices AD7170/AD7171/AD7780/AD7781 > + > +Data sheets: > + > +- AD7170: > + * https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf > +- AD7171: > + * https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf > +- AD7780: > + * https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf > +- AD7781: > + * https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf > + > +Required properties: > + > +- compatible: should be one of > + * "adi,ad7170" > + * "adi,ad7171" > + * "adi,ad7780" > + * "adi,ad7781" > +- reg: spi chip select number for the device > +- vref-supply: the regulator supply for the ADC reference voltage > + > +Optional properties: > + > +- powerdown-gpios: must be the device tree identifier of the PDRST pin. If > + specified, it will be asserted during driver probe. As the > + line is active high, it should be marked GPIO_ACTIVE_HIGH. > +- adi,gain-gpios: must be the device tree identifier of the GAIN pin. Only for > + the ad778x chips. If specified, it will be asserted during > + driver probe. As the line is active low, it should be marked > + GPIO_ACTIVE_LOW. > +- adi,filter-gpios: must be the device tree identifier of the FILTER pin. Only > + for the ad778x chips. If specified, it will be asserted > + during driver probe. As the line is active low, it should be > + marked GPIO_ACTIVE_LOW. > + > +Example: > + > +adc@0 { > + compatible = "adi,ad7780"; > + reg = <0>; > + vref-supply = <&vdd_supply> > + > + powerdown-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>; > + adi,gain-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; > + adi,filter-gpios = <&gpio 15 GPIO_ACTIVE_LOW>; > +};