linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Bárbara Fernandes" <barbara.fernandes@usp.br>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-usp@googlegroups.com
Subject: Re: [PATCH 4/4] iio:adc:ad7923: Rewrite comparison to NULL
Date: Sun, 3 Mar 2019 14:47:32 +0000	[thread overview]
Message-ID: <20190303144732.38f57096@archlinux> (raw)
In-Reply-To: <20190222203159.15116-5-barbara.fernandes@usp.br>

On Fri, 22 Feb 2019 17:31:59 -0300
Bárbara Fernandes <barbara.fernandes@usp.br> wrote:

> Solves checkpath.pl's message:
> 
> CHECK: Comparison to NULL could be written "!indio_dev"
> 
> Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
Applied, thanks.

It's nice to get some cleanup for drivers that aren't in staging
sometimes.  After all, in recent years the kernel coding style
and tools to check it have improved considerably.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ad7923.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c
> index dbece44e26e4..cb7b854df00c 100644
> --- a/drivers/iio/adc/ad7923.c
> +++ b/drivers/iio/adc/ad7923.c
> @@ -272,7 +272,7 @@ static int ad7923_probe(struct spi_device *spi)
>  	int ret;
>  
>  	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> -	if (indio_dev == NULL)
> +	if (!indio_dev)
>  		return -ENOMEM;
>  
>  	st = iio_priv(indio_dev);


      reply	other threads:[~2019-03-03 14:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 20:31 [PATCH 0/4] Solve checkstyle problems Bárbara Fernandes
2019-02-22 20:31 ` [PATCH 1/4] iio:adc:ad7923: Align broken line to parenthesis Bárbara Fernandes
2019-03-03 14:43   ` Jonathan Cameron
2019-02-22 20:31 ` [PATCH 2/4] iio:adc:ad7923: Use BIT macro instead of bitshift Bárbara Fernandes
2019-03-03 14:44   ` Jonathan Cameron
2019-02-22 20:31 ` [PATCH 3/4] iio:adc:ad7923: Put macro argument between ()'s Bárbara Fernandes
2019-03-03 14:45   ` Jonathan Cameron
2019-02-22 20:31 ` [PATCH 4/4] iio:adc:ad7923: Rewrite comparison to NULL Bárbara Fernandes
2019-03-03 14:47   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190303144732.38f57096@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=barbara.fernandes@usp.br \
    --cc=kernel-usp@googlegroups.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).