From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B287DC43381 for ; Sun, 3 Mar 2019 14:47:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7463620866 for ; Sun, 3 Mar 2019 14:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551624458; bh=Ldejzf8jupG2qN/3MS05lPeJ0Rmi6kaNmQH+mgKbkHI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=tWUqkQx8F+N91Gpyq8FL2iS0Dpiou7DsSLU3njcW2WiB9jVgpbFiCAhbBRrC0MgEY n1hqwJmkSOvbY9PQK5rzi/LPFWoXsaYqvjs6N4Raw6zNwO0kOge6TuRGJ5AP5Ep/GN 0oAxM1QrO+wxMM6zY7uu6qYMeLryq5IJVUexPTW4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726252AbfCCOri (ORCPT ); Sun, 3 Mar 2019 09:47:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:48518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726217AbfCCOrh (ORCPT ); Sun, 3 Mar 2019 09:47:37 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69CCB20835; Sun, 3 Mar 2019 14:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551624457; bh=Ldejzf8jupG2qN/3MS05lPeJ0Rmi6kaNmQH+mgKbkHI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZSvZ3aazne/NZRPZrMkAJpzRyziwjO0veMEyd0aO7eR2/9csUJJPspjsFBWS4yIst 50pR7nnk0bJDyuYrrHukgHJKuv6TUyY3/Z0U1dKgFON6AN56E7O4V3n0rEODUrA5Qm 1eItRKuIF9o3bc4mYkxD4hld8iYLEXS1CVoXjOIc= Date: Sun, 3 Mar 2019 14:47:32 +0000 From: Jonathan Cameron To: =?UTF-8?B?QsOhcmJhcmE=?= Fernandes Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: Re: [PATCH 4/4] iio:adc:ad7923: Rewrite comparison to NULL Message-ID: <20190303144732.38f57096@archlinux> In-Reply-To: <20190222203159.15116-5-barbara.fernandes@usp.br> References: <20190222203159.15116-1-barbara.fernandes@usp.br> <20190222203159.15116-5-barbara.fernandes@usp.br> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 22 Feb 2019 17:31:59 -0300 B=C3=A1rbara Fernandes wrote: > Solves checkpath.pl's message: >=20 > CHECK: Comparison to NULL could be written "!indio_dev" >=20 > Signed-off-by: B=C3=A1rbara Fernandes Applied, thanks. It's nice to get some cleanup for drivers that aren't in staging sometimes. After all, in recent years the kernel coding style and tools to check it have improved considerably. Thanks, Jonathan > --- > drivers/iio/adc/ad7923.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c > index dbece44e26e4..cb7b854df00c 100644 > --- a/drivers/iio/adc/ad7923.c > +++ b/drivers/iio/adc/ad7923.c > @@ -272,7 +272,7 @@ static int ad7923_probe(struct spi_device *spi) > int ret; > =20 > indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); > - if (indio_dev =3D=3D NULL) > + if (!indio_dev) > return -ENOMEM; > =20 > st =3D iio_priv(indio_dev);