From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06F4C43381 for ; Sat, 9 Mar 2019 05:03:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A72612081B for ; Sat, 9 Mar 2019 05:03:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="qwUETuKD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725616AbfCIFDv (ORCPT ); Sat, 9 Mar 2019 00:03:51 -0500 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:57206 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725613AbfCIFDu (ORCPT ); Sat, 9 Mar 2019 00:03:50 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id 6971D71B for ; Sat, 9 Mar 2019 04:54:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l2rpDkuyux0O for ; Fri, 8 Mar 2019 22:54:06 -0600 (CST) Received: from mail-it1-f198.google.com (mail-it1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 3A746713 for ; Fri, 8 Mar 2019 22:54:06 -0600 (CST) Received: by mail-it1-f198.google.com with SMTP id 9so13530062ita.8 for ; Fri, 08 Mar 2019 20:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=3JMsAjn5exKlEerExLOrVHDarRBcXTjOMDi86JDw2+U=; b=qwUETuKDZcJpVArTZNRUR7RtzUtuWhESAeC/SVjN5jngLhqSRyOtseAcd7y66Y+eKi C5o478MXZGkVEUW2mD9//BO8XDwnuihewujQl8MYZXMhbvfvqy/bbyTOTB9DwczowoUd Uec5IE93ZK8X+O4cIRhlD29+3Z1QH8ppnqDgxzuXLW6d0hNzrDtcPLpq2PUK0rjTXkPb 9vsXpCoOIC8LOLQcYRrWmWm/jf5hnjz0gQRMfzkw9P0nGTombENY5Q3/z+/PMQcOV5DV C5wEDGjDBXj5mFFPf/dqAjqorJvqcmB/PngazNu1322quyNbh2FiID4zktaf/U+ci4ii pw3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3JMsAjn5exKlEerExLOrVHDarRBcXTjOMDi86JDw2+U=; b=HePwFs0DIfZlPudhls19QzssyNqn66393mOxQEK7OY122XqG3luB9tHIsywdGl0V1f I4G/HoAf2f3nQAN5WcXehrhpyL5MyFVnCv9JjAL3wBkXgSPiKs2lTB03zRNrDA/nCDwO ZV2jIZGj8inMLXQbWBqnvDrbtk0e6Re2nHEMwHzUNCcs3+VWihfHhyIKaU8BXhN5Lkf8 +wCYx+h9lZdaCKlRsoZ8+DKVXmJWHP3rf8vL/fasgbFdCMY+lxxn1QJqhQeHwYC5u8JB D0K6OX7UvC3MBgczchelismlSHw0vYFL/MvsZc1m8l4rcBIRBCE81XJV8mMkm47ERGlp BU8Q== X-Gm-Message-State: APjAAAXbJtrDKI77sofV86j6UeAV9yBSvvkVWmhV4vuNZO3BaEpQQMKn xl4FkjsP5SvxyCAZZ+26IemYS+cp+Higf59UvsY1JjAK/OGNqqxw3beFg3tYz+sjxYpYqLZ2o2D Tn0TJxTeLaWW/dbGN20wvakJi X-Received: by 2002:a6b:ef12:: with SMTP id k18mr4326324ioh.171.1552107245822; Fri, 08 Mar 2019 20:54:05 -0800 (PST) X-Google-Smtp-Source: APXvYqy981E6VHOFnqLjR1hxMuSwXGxvkzEZIe67wYpWJ8FCYIcLhFDQIYTmuWZJ0uxZXqEzYJQvRQ== X-Received: by 2002:a6b:ef12:: with SMTP id k18mr4326311ioh.171.1552107245568; Fri, 08 Mar 2019 20:54:05 -0800 (PST) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id x84sm4827153ita.32.2019.03.08.20.54.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 20:54:04 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: adc: fix a potential NULL pointer dereference Date: Fri, 8 Mar 2019 22:53:55 -0600 Message-Id: <20190309045356.8892-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org devm_iio_trigger_alloc may fail and return NULL. The fix returns ENOMEM when it fails. Signed-off-by: Kangjie Lu --- drivers/iio/adc/mxs-lradc-adc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c index c627513d9f0f..5384472b6c4d 100644 --- a/drivers/iio/adc/mxs-lradc-adc.c +++ b/drivers/iio/adc/mxs-lradc-adc.c @@ -465,6 +465,8 @@ static int mxs_lradc_adc_trigger_init(struct iio_dev *iio) trig = devm_iio_trigger_alloc(&iio->dev, "%s-dev%i", iio->name, iio->id); + if (!trig) + return -ENOMEM; trig->dev.parent = adc->dev; iio_trigger_set_drvdata(trig, iio); -- 2.17.1