Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

Alexandru Ardelean
2019-03-11T08:13:02Z

On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio
<karen.palacio.1994@gmail.com> wrote:
>
> Add spaces around minus operator to fix readibility.
>
> Signed-off-by: Karen Palacio <karen.palacio.1994@gmail.com>
> ---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index acdbc07..7c632cf 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev,
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> - in_voltage-voltage_scale_available,
> + in_voltage - voltage_scale_available,

This isn't broken, but I do agree it should be addressed.
I think it's the second time I see a similar patch trying to fix this.
So, obviously the code is a bit misleading.

> 0444, ad7192_show_scale_available, NULL, 0);
>
> static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> --
> 2.7.4
>