Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

Jonathan Cameron
2019-03-16T15:59:44Z

On Mon, 11 Mar 2019 11:31:59 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> On Mon, Mar 11, 2019 at 10:12:48AM +0200, Alexandru Ardelean wrote:
> > On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio
> > <karen.palacio.1994@gmail.com> wrote:
> > >
> > > Add spaces around minus operator to fix readibility.
> > >
> > > Signed-off-by: Karen Palacio <karen.palacio.1994@gmail.com>
> > > ---
> > > drivers/staging/iio/adc/ad7192.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > > index acdbc07..7c632cf 100644
> > > --- a/drivers/staging/iio/adc/ad7192.c
> > > +++ b/drivers/staging/iio/adc/ad7192.c
> > > @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev,
> > > }
> > >
> > > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> > > - in_voltage-voltage_scale_available,
> > > + in_voltage - voltage_scale_available,
> >
> > This isn't broken, but I do agree it should be addressed.
> > I think it's the second time I see a similar patch trying to fix this.
> > So, obviously the code is a bit misleading.
> >
>
> It's got to be more than that. I did a simple grep of my inbox and it
> says that this is the 13th time someone has tried to do this. It's
> possible that my grep is wrong, 13 seems high but not totaly impossible.

That sounds about right.

Best bet is to move this over to the read_avail callback and do it using
the core handling for available attributes which will build the name
in code so checkpatch won't find it.

Anyone want to spin up a patch to do that and save anyone else wasting
time on this? Or we could just put a comment right next to it and hope
people read it..

Thanks,

Jonathan

>
> regards,
> dan carpenter
>