Re: [PATCH v2] iio: dac: mcp4725: add missing powerdown bits in store eeprom

Jean-Francois Dagenais
2019-03-12T12:32:26Z

> On Mar 11, 2019, at 07:42, Jean-Francois Dagenais <jeff.dagenais@gmail.com> wrote:
>
> When issuing the write DAC register and write eeprom command, the two
> powerdown bits (PD0 and PD1) are assumed by the chip to be present in
> the bytes sent. Leaving them at 0 implies "powerdown disabled" which is
> a different state that the current one. By adding the current state of
> the powerdown in the i2c write, the chip will correctly power-on exactly
> like as it is at the moment of store_eeprom call.
>
> This is documented in MCP4725's datasheet, FIGURE 6-2: "Write Commands
> for DAC Input Register and EEPROM" and MCP4726's datasheet, FIGURE 6-3:
> "Write All Memory Command".
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
> ---

I forgot to add:

Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>

in v2

v3 just for that?