Re: [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER

Tomasz Duszynski
2019-03-14T17:28:04Z

On Thu, Mar 14, 2019 at 10:00:52AM +0100, Arnd Bergmann wrote:
> Without IIO_TRIGGERED_BUFFER, this driver fails to link:

Good catch, thanks (btw, perhaps typo in subject can be fixed before
applying patch).

Acked-by: Tomasz Duszynski <tduszyns@gmail.com>

>
> drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
> pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
> pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'
>
> Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/iio/chemical/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> index d5d146e9e372..6f253092a523 100644
> --- a/drivers/iio/chemical/Kconfig
> +++ b/drivers/iio/chemical/Kconfig
> @@ -64,6 +64,7 @@ config IAQCORE
> config PMS7003
> tristate "Plantower PMS7003 particulate matter sensor"
> depends on SERIAL_DEV_BUS
> + select IIO_TRIGGERED_BUFFER
> help
> Say Y here to build support for the Plantower PMS7003 particulate
> matter sensor.
> --
> 2.20.0
>