[PATCH 2/3] staging: iio: ad7280a: Add parentheses to macros

Vladimir Petrigo
2019-03-17T20:53:25Z

Fix CHECK Macro argument 'c' may be better as '(c)' to
avoid precedence issues

Signed-off-by: Vladimir Petrigo <vladimir.petrigo@gmail.com>

diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c index d9df126..98cf876
100644 --- a/drivers/staging/iio/adc/ad7280a.c +++
b/drivers/staging/iio/adc/ad7280a.c @@ -97,9 +97,9 @@
#define AD7280A_NUM_CH (AD7280A_AUX_ADC_6 - \
AD7280A_CELL_VOLTAGE_1
+ 1)

-#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) ((d *
AD7280A_CELLS_PER_DEV) + c) -#define
AD7280A_CALC_TEMP_CHAN_NUM(d, c) ((d *
AD7280A_CELLS_PER_DEV) + \ - c - AD7280A_CELLS_PER_DEV)
+#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) (((d) *
AD7280A_CELLS_PER_DEV) + (c)) +#define
AD7280A_CALC_TEMP_CHAN_NUM(d, c) (((d) *
AD7280A_CELLS_PER_DEV) + \ + (c) - AD7280A_CELLS_PER_DEV)

#define AD7280A_DEVADDR_MASTER 0 define
#AD7280A_DEVADDR_ALL 0x1F
---
drivers/staging/iio/adc/ad7280a.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index d9df126..98cf876 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -97,9 +97,9 @@
#define AD7280A_NUM_CH (AD7280A_AUX_ADC_6 - \
AD7280A_CELL_VOLTAGE_1 + 1)

-#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) ((d * AD7280A_CELLS_PER_DEV) + c)
-#define AD7280A_CALC_TEMP_CHAN_NUM(d, c) ((d * AD7280A_CELLS_PER_DEV) + \
- c - AD7280A_CELLS_PER_DEV)
+#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) (((d) * AD7280A_CELLS_PER_DEV) + (c))
+#define AD7280A_CALC_TEMP_CHAN_NUM(d, c) (((d) * AD7280A_CELLS_PER_DEV) + \
+ (c) - AD7280A_CELLS_PER_DEV)

#define AD7280A_DEVADDR_MASTER 0
#define AD7280A_DEVADDR_ALL 0x1F
--
2.7.4