From: "Angus Ainslie (Purism)" <angus@akkea.ca>
To: jic23@kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Angus Ainslie (Purism)" <angus@akkea.ca>,
Tomas Novotny <tomas@novotny.cz>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/5] iio: light: vcnl4000 use word writes instead of byte writes
Date: Thu, 21 Mar 2019 08:40:43 -0700 [thread overview]
Message-ID: <20190321154047.23236-2-angus@akkea.ca> (raw)
In-Reply-To: <20190321154047.23236-1-angus@akkea.ca>
The VCNL4200 datasheet says that word read and writes should be used
to access the registers.
Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
Tested-by: Tomas Novotny <tomas@novotny.cz>
---
drivers/iio/light/vcnl4000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 04fd0d4b6f19..5e0a8eb83ebc 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -140,10 +140,10 @@ static int vcnl4200_init(struct vcnl4000_data *data)
data->rev = (ret >> 8) & 0xf;
/* Set defaults and enable both channels */
- ret = i2c_smbus_write_byte_data(data->client, VCNL4200_AL_CONF, 0x00);
+ ret = i2c_smbus_write_word_data(data->client, VCNL4200_AL_CONF, 0);
if (ret < 0)
return ret;
- ret = i2c_smbus_write_byte_data(data->client, VCNL4200_PS_CONF1, 0x00);
+ ret = i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1, 0);
if (ret < 0)
return ret;
--
2.17.1
next prev parent reply other threads:[~2019-03-21 15:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 15:40 [PATCH v3 0/5] Add a VCNL4040 light and proximity driver Angus Ainslie (Purism)
2019-03-21 15:40 ` Angus Ainslie (Purism) [this message]
2019-03-24 17:18 ` [PATCH v3 1/5] iio: light: vcnl4000 use word writes instead of byte writes Jonathan Cameron
2019-03-21 15:40 ` [PATCH v3 2/5] iio: light: vcnl4000 add devicetree hooks Angus Ainslie (Purism)
2019-03-24 17:19 ` Jonathan Cameron
2019-03-24 17:22 ` Jonathan Cameron
2019-03-21 15:40 ` [PATCH v3 3/5] dt-bindings: iio: light: add vcnl4000 devicetree bindings Angus Ainslie (Purism)
2019-03-24 17:20 ` Jonathan Cameron
2019-03-28 17:53 ` Rob Herring
2019-03-21 15:40 ` [PATCH v3 4/5] iio: light: vcnl4000 add support for the VCNL4040 proximity and light sensor Angus Ainslie (Purism)
2019-03-24 17:24 ` Jonathan Cameron
2019-03-21 15:40 ` [PATCH v3 5/5] dt-bindings: iio: light: add vcnl4040 devicetree bindings Angus Ainslie (Purism)
2019-03-24 17:25 ` Jonathan Cameron
2019-03-28 17:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321154047.23236-2-angus@akkea.ca \
--to=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=tomas@novotny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).