From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25566C43381 for ; Sun, 24 Mar 2019 12:41:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9B31222D6 for ; Sun, 24 Mar 2019 12:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553431310; bh=/bx/xq5WecKtE5kx7fM8MrdOKvn/UgVI75BPjnbSiKA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=WyUmQlxJEX5jgItoBzed7moFhguwojgLs2pgs65ZJX9wlF/HBmIpUzVOiWel5hD/7 C2FZmnj5py/5jbUs72a24/LedqgODY1v6q/JJdGvL7oB6e19y1X10df7a0Qi2rVS34 GSbOg8O5bfJHIsYV2P3MzagmY5fwfaUpuR68eZzQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726889AbfCXMlu (ORCPT ); Sun, 24 Mar 2019 08:41:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:52416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbfCXMlu (ORCPT ); Sun, 24 Mar 2019 08:41:50 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81F17222D0; Sun, 24 Mar 2019 12:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553431309; bh=/bx/xq5WecKtE5kx7fM8MrdOKvn/UgVI75BPjnbSiKA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZnHy/Uifugz7m0HqwVCT/WENuI71kNypdceLxTp1A5cyEmMVmmB0XFdgRdsjm4Vfw EuyW8K36VK0oysTwkJzyzuKwiBZihbpPcWPPEqKxGoXfHuDvSojX+H0IwzpmdoEgEe TtVR4vt82U0O4orkHV8BlMY2qatV2foLoepl8z3s= Date: Sun, 24 Mar 2019 12:41:43 +0000 From: Jonathan Cameron To: Cristian Sicilia Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] staging: iio: adc: Adding temp var to improve readability Message-ID: <20190324124143.72c950f4@archlinux> In-Reply-To: <82dd56df8d410ec91061ef51c2653345d7e30aa2.1553366098.git.sicilia.cristian@gmail.com> References: <82dd56df8d410ec91061ef51c2653345d7e30aa2.1553366098.git.sicilia.cristian@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, 23 Mar 2019 20:21:45 +0100 Cristian Sicilia wrote: > Creating a temporary variable to improve readability > > Signed-off-by: Cristian Sicilia Indeed makes it a little more readable, so fair enough. Applied Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 55 ++++++++++++++++++--------------------- > 1 file changed, 25 insertions(+), 30 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c > index d81a5bd..5d848aa 100644 > --- a/drivers/staging/iio/adc/ad7280a.c > +++ b/drivers/staging/iio/adc/ad7280a.c > @@ -784,43 +784,38 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) > for (i = 0; i < st->scan_cnt; i++) { > if (((channels[i] >> 23) & 0xF) <= AD7280A_CELL_VOLTAGE_6) { > if (((channels[i] >> 11) & 0xFFF) >= > - st->cell_threshhigh) > - iio_push_event(indio_dev, > - IIO_EVENT_CODE(IIO_VOLTAGE, > - 1, > - 0, > - IIO_EV_DIR_RISING, > - IIO_EV_TYPE_THRESH, > - 0, 0, 0), > + st->cell_threshhigh) { > + u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0, > + IIO_EV_DIR_RISING, > + IIO_EV_TYPE_THRESH, > + 0, 0, 0); > + iio_push_event(indio_dev, tmp, > iio_get_time_ns(indio_dev)); > - else if (((channels[i] >> 11) & 0xFFF) <= > - st->cell_threshlow) > - iio_push_event(indio_dev, > - IIO_EVENT_CODE(IIO_VOLTAGE, > - 1, > - 0, > - IIO_EV_DIR_FALLING, > - IIO_EV_TYPE_THRESH, > - 0, 0, 0), > + } else if (((channels[i] >> 11) & 0xFFF) <= > + st->cell_threshlow) { > + u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0, > + IIO_EV_DIR_FALLING, > + IIO_EV_TYPE_THRESH, > + 0, 0, 0); > + iio_push_event(indio_dev, tmp, > iio_get_time_ns(indio_dev)); > + } > } else { > - if (((channels[i] >> 11) & 0xFFF) >= st->aux_threshhigh) > - iio_push_event(indio_dev, > - IIO_UNMOD_EVENT_CODE( > - IIO_TEMP, > - 0, > + if (((channels[i] >> 11) & 0xFFF) >= > + st->aux_threshhigh) { > + u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0, > IIO_EV_TYPE_THRESH, > - IIO_EV_DIR_RISING), > + IIO_EV_DIR_RISING); > + iio_push_event(indio_dev, tmp, > iio_get_time_ns(indio_dev)); > - else if (((channels[i] >> 11) & 0xFFF) <= > - st->aux_threshlow) > - iio_push_event(indio_dev, > - IIO_UNMOD_EVENT_CODE( > - IIO_TEMP, > - 0, > + } else if (((channels[i] >> 11) & 0xFFF) <= > + st->aux_threshlow) { > + u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0, > IIO_EV_TYPE_THRESH, > - IIO_EV_DIR_FALLING), > + IIO_EV_DIR_FALLING); > + iio_push_event(indio_dev, tmp, > iio_get_time_ns(indio_dev)); > + } > } > } >