From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30FAC43381 for ; Sun, 24 Mar 2019 15:27:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6742F20830 for ; Sun, 24 Mar 2019 15:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553441277; bh=wmMFp47rXKkrxSNQ39fudLAGZy1dhilPCEU94iny3Lo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=IVYPbVrmsK5txKc7CoftnvicHQ9MWXxD9F89hOiVpZ7mgDR57kjasAnn/xvBaPMmm 1D0RfoFQbeTLJBTO9WE0drp31e7wpVWIkxgGKt1eIUCOu+SPzWXpNJkta1Rr2/k985 27gavZNzIxUvhNpb+AaA9v3RbRul/mJM+1n4/fcU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727211AbfCXP15 (ORCPT ); Sun, 24 Mar 2019 11:27:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:59180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbfCXP14 (ORCPT ); Sun, 24 Mar 2019 11:27:56 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 455E020700; Sun, 24 Mar 2019 15:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553441276; bh=wmMFp47rXKkrxSNQ39fudLAGZy1dhilPCEU94iny3Lo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lHFslGF+2IZPcFf1/f/mHKwkaSv5K+BqGROyFejzutS4O7zD1URW5zuhpU2MEGbud 6mQ7maGEwn9VgZ2C+iVjAHDSIM/4VsoNG4z9ORsuDEfwTpQGOfGRwSsINfiTuhn9S2 EkB5cKI1qQB/IawNgaFz6Kb7lF28qdlWX8l3YsB0= Date: Sun, 24 Mar 2019 15:27:50 +0000 From: Jonathan Cameron To: Artur Rojek Cc: Sebastian Reichel , Rob Herring , Mark Rutland , linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil Subject: Re: [PATCH v2 2/4] iio: inkern: Convert iio_read_avail_channel_raw into a wrapper Message-ID: <20190324152750.43edf737@archlinux> In-Reply-To: <20190323172809.14407-2-contact@artur-rojek.eu> References: <20190323172809.14407-1-contact@artur-rojek.eu> <20190323172809.14407-2-contact@artur-rojek.eu> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, 23 Mar 2019 18:28:07 +0100 Artur Rojek wrote: > Convert "iio_read_avail_channel_raw" over to a wrapper around > "iio_read_avail_channel_attribute". > > With the introduction of "iio_read_avail_channel_attribute", > the necessity of having a separate call to read raw channel values > became redundant. > > Signed-off-by: Artur Rojek Acked-by: Jonathan Cameron > --- > > Changes: > > v2: new patch > > drivers/iio/inkern.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c > index f19dbde3c945..4a5eff3f18bc 100644 > --- a/drivers/iio/inkern.c > +++ b/drivers/iio/inkern.c > @@ -759,16 +759,8 @@ int iio_read_avail_channel_raw(struct iio_channel *chan, > int ret; > int type; > > - mutex_lock(&chan->indio_dev->info_exist_lock); > - if (!chan->indio_dev->info) { > - ret = -ENODEV; > - goto err_unlock; > - } > - > - ret = iio_channel_read_avail(chan, > - vals, &type, length, IIO_CHAN_INFO_RAW); > -err_unlock: > - mutex_unlock(&chan->indio_dev->info_exist_lock); > + ret = iio_read_avail_channel_attribute(chan, vals, &type, length, > + IIO_CHAN_INFO_RAW); > > if (ret >= 0 && type != IIO_VAL_INT) > /* raw values are assumed to be IIO_VAL_INT */