From: Jonathan Cameron <jic23@kernel.org>
To: Vladimir Petrigo <vladimir.petrigo@gmail.com>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH v2 1/2] staging: iio: ad7280a: Add parentheses to macros
Date: Sun, 24 Mar 2019 16:04:55 +0000 [thread overview]
Message-ID: <20190324160455.1cc494e9@archlinux> (raw)
In-Reply-To: <1553202928-34824-2-git-send-email-vladimir.petrigo@gmail.com>
On Fri, 22 Mar 2019 00:15:27 +0300
Vladimir Petrigo <vladimir.petrigo@gmail.com> wrote:
> - Fix CHECK Macro argument 'c' may be better as '(c)' to avoid precedence issues
> - Fix CHECK Macro argument 'd' may be better as '(d)' to avoid precedence issues
>
> Signed-off-by: Vladimir Petrigo <vladimir.petrigo@gmail.com>
Sorry, I ended up taking Cristian's patch for the same issue.
No particular reason other than which email I hit first!
Jonathan
> ---
> drivers/staging/iio/adc/ad7280a.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index d9df126..98cf876 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -97,9 +97,9 @@
> #define AD7280A_NUM_CH (AD7280A_AUX_ADC_6 - \
> AD7280A_CELL_VOLTAGE_1 + 1)
>
> -#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) ((d * AD7280A_CELLS_PER_DEV) + c)
> -#define AD7280A_CALC_TEMP_CHAN_NUM(d, c) ((d * AD7280A_CELLS_PER_DEV) + \
> - c - AD7280A_CELLS_PER_DEV)
> +#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) (((d) * AD7280A_CELLS_PER_DEV) + (c))
> +#define AD7280A_CALC_TEMP_CHAN_NUM(d, c) (((d) * AD7280A_CELLS_PER_DEV) + \
> + (c) - AD7280A_CELLS_PER_DEV)
>
> #define AD7280A_DEVADDR_MASTER 0
> #define AD7280A_DEVADDR_ALL 0x1F
next prev parent reply other threads:[~2019-03-24 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 21:15 [PATCH v2 0/2] staging: iio: adc: Fix code formatting issues Vladimir Petrigo
2019-03-21 21:15 ` [PATCH v2 1/2] staging: iio: ad7280a: Add parentheses to macros Vladimir Petrigo
2019-03-24 16:04 ` Jonathan Cameron [this message]
2019-03-21 21:15 ` [PATCH v2 2/2] staging: iio: ad7780: " Vladimir Petrigo
2019-03-24 16:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324160455.1cc494e9@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=vladimir.petrigo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox