From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, Dragos Bogdan <dragos.bogdan@analog.com>
Subject: Re: [PATCH] iio: ad_sigma_delta: select channel when reading register
Date: Sun, 24 Mar 2019 17:51:46 +0000 [thread overview]
Message-ID: <20190324175146.0fd060d8@archlinux> (raw)
In-Reply-To: <20190319104700.28357-1-alexandru.ardelean@analog.com>
On Tue, 19 Mar 2019 12:47:00 +0200
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> From: Dragos Bogdan <dragos.bogdan@analog.com>
>
> The desired channel has to be selected in order to correctly fill the
> buffer with the corresponding data.
> The `ad_sd_write_reg()` already does this, but for the
> `ad_sd_read_reg_raw()` this was omitted.
>
> Fixes: af3008485ea03 ("iio:adc: Add common code for ADI Sigma Delta devices")
> Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ad_sigma_delta.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
> index ff5f2da2e1b1..54d9978b2740 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -121,6 +121,7 @@ static int ad_sd_read_reg_raw(struct ad_sigma_delta *sigma_delta,
> if (sigma_delta->info->has_registers) {
> data[0] = reg << sigma_delta->info->addr_shift;
> data[0] |= sigma_delta->info->read_mask;
> + data[0] |= sigma_delta->comm;
> spi_message_add_tail(&t[0], &m);
> }
> spi_message_add_tail(&t[1], &m);
prev parent reply other threads:[~2019-03-24 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 10:47 [PATCH] iio: ad_sigma_delta: select channel when reading register Alexandru Ardelean
2019-03-24 17:51 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324175146.0fd060d8@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=alexandru.ardelean@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).