Re: [PATCH v1] iio: adc: intel_mrfld_adc: Add Basin Cove ADC driver

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Sun, Mar 24, 2019 at 12:22:44PM +0000, Jonathan Cameron wrote:
> On Tue, 19 Mar 2019 23:25:07 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Mar 19, 2019 at 08:02:15PM +0100, Tomasz Duszynski wrote:
> > > On Tue, Mar 19, 2019 at 12:37:28AM +0200, Andy Shevchenko wrote:  
> > > > On Mon, Mar 18, 2019 at 09:52:42PM +0100, Tomasz Duszynski wrote:  
> > > > > On Mon, Mar 18, 2019 at 12:51:03PM +0300, Andy Shevchenko wrote:  
> > 
> > > > > > +#include <linux/iio/iio.h>
> > > > > > +#include <linux/iio/driver.h>
> > > > > > +#include <linux/iio/machine.h>  
> > 
> > > > > Alphabetical order is preferred.  
> > > >
> > > > Ah, you meant iio.h vs. driver.h?
> > > >  
> > > 
> > > Yes.  
> > 
> > It won't compile in alphabetical order.
> 
> That's a little worrying as this should definitely not be order dependant.
> What was the error? 
> 
> Ah, I'm guessing struct iio_dev not defined.
> If you would like to put a patch in to add that forward definition in driver.h
> that would be great.  Its an omission rather than intentional.

Done.

> Any chance of getting the whole MFD including this buildable with COMPILE_TEST?

Not possible. MFD includes the x86 architecture provided header.

> Otherwise coverage likely to be somewhat reduced (I probably won't build it
> normally for starters!)

This driver itself may be compile tested separately.

Would you like me to add something like

	depends on X86 || COMPILE_TEST

?

-- 
With Best Regards,
Andy Shevchenko