From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v1] iio: Make possible to include driver.h first
Date: Sat, 30 Mar 2019 15:04:23 +0000 [thread overview]
Message-ID: <20190330150423.538d2476@archlinux> (raw)
In-Reply-To: <20190326134700.24800-1-andriy.shevchenko@linux.intel.com>
On Tue, 26 Mar 2019 15:47:00 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> If we put headers alphabetically sorted in the IIO driver,
> the compilation will abort because of unknown type to handle.
>
> Simple add a forward declaration of opaque struct iio_dev.
>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied,
Thanks,
Jonathan
> ---
> include/linux/iio/driver.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/iio/driver.h b/include/linux/iio/driver.h
> index 7dfb10ee2669..f54a7bcdefe3 100644
> --- a/include/linux/iio/driver.h
> +++ b/include/linux/iio/driver.h
> @@ -11,6 +11,7 @@
> #ifndef _IIO_INKERN_H_
> #define _IIO_INKERN_H_
>
> +struct iio_dev;
> struct iio_map;
>
> /**
prev parent reply other threads:[~2019-03-30 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 13:47 [PATCH v1] iio: Make possible to include driver.h first Andy Shevchenko
2019-03-30 15:04 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190330150423.538d2476@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).