linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Camylla Gonçalves Cantanheide" <c.cantanheide@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-usp@googlegroups.com
Subject: Re: [PATCH] iio: adc: ad7766: Change alignment to match paranthesis
Date: Thu, 4 Apr 2019 20:59:46 +0100	[thread overview]
Message-ID: <20190404205946.5d5b0a88@archlinux> (raw)
In-Reply-To: <20190224214010.10894-1-c.cantanheide@gmail.com>

On Sun, 24 Feb 2019 18:40:10 -0300
Camylla Gonçalves Cantanheide <c.cantanheide@gmail.com> wrote:

> This commit align broken line to match upper line parenthesis,
> in lines 80, 130, 237, 242, 255, 264 and 293. Solves the checkpatch.pl's message:
> 
> CHECK: Alignment should match open parenthesis
> 
> In lines 130, 255, 264 and 293 it was necessary to break a line.
I missed this at the time, but Greg caught it in the pull request.

No Sign-off so we can't take it (see Developer Certificate or Origin for
why).  Please resend with a sign off and I'll get it queued up for next
time.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/ad7766.c | 22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7766.c b/drivers/iio/adc/ad7766.c
> index 3ae14fc8c649..101502435768 100644
> --- a/drivers/iio/adc/ad7766.c
> +++ b/drivers/iio/adc/ad7766.c
> @@ -77,7 +77,7 @@ static irqreturn_t ad7766_trigger_handler(int irq, void *p)
>  		goto done;
>  
>  	iio_push_to_buffers_with_timestamp(indio_dev, ad7766->data,
> -		pf->timestamp);
> +					   pf->timestamp);
>  done:
>  	iio_trigger_notify_done(indio_dev->trig);
>  
> @@ -127,7 +127,8 @@ static int ad7766_postdisable(struct iio_dev *indio_dev)
>  }
>  
>  static int ad7766_read_raw(struct iio_dev *indio_dev,
> -	const struct iio_chan_spec *chan, int *val, int *val2, long info)
> +			   const struct iio_chan_spec *chan, int *val,
> +			   int *val2, long info)
>  {
>  	struct ad7766 *ad7766 = iio_priv(indio_dev);
>  	struct regulator *vref = ad7766->reg[AD7766_SUPPLY_VREF].consumer;
> @@ -234,12 +235,12 @@ static int ad7766_probe(struct spi_device *spi)
>  	ad7766->reg[AD7766_SUPPLY_VREF].supply = "vref";
>  
>  	ret = devm_regulator_bulk_get(&spi->dev, ARRAY_SIZE(ad7766->reg),
> -		ad7766->reg);
> +				      ad7766->reg);
>  	if (ret)
>  		return ret;
>  
>  	ad7766->pd_gpio = devm_gpiod_get_optional(&spi->dev, "powerdown",
> -		GPIOD_OUT_HIGH);
> +						  GPIOD_OUT_HIGH);
>  	if (IS_ERR(ad7766->pd_gpio))
>  		return PTR_ERR(ad7766->pd_gpio);
>  
> @@ -252,7 +253,8 @@ static int ad7766_probe(struct spi_device *spi)
>  
>  	if (spi->irq > 0) {
>  		ad7766->trig = devm_iio_trigger_alloc(&spi->dev, "%s-dev%d",
> -			indio_dev->name, indio_dev->id);
> +						      indio_dev->name,
> +						      indio_dev->id);
>  		if (!ad7766->trig)
>  			return -ENOMEM;
>  
> @@ -261,8 +263,9 @@ static int ad7766_probe(struct spi_device *spi)
>  		iio_trigger_set_drvdata(ad7766->trig, ad7766);
>  
>  		ret = devm_request_irq(&spi->dev, spi->irq, ad7766_irq,
> -			IRQF_TRIGGER_FALLING, dev_name(&spi->dev),
> -			ad7766->trig);
> +				       IRQF_TRIGGER_FALLING,
> +				       dev_name(&spi->dev),
> +				       ad7766->trig);
>  		if (ret < 0)
>  			return ret;
>  
> @@ -290,8 +293,9 @@ static int ad7766_probe(struct spi_device *spi)
>  	spi_message_add_tail(&ad7766->xfer, &ad7766->msg);
>  
>  	ret = devm_iio_triggered_buffer_setup(&spi->dev, indio_dev,
> -		&iio_pollfunc_store_time, &ad7766_trigger_handler,
> -		&ad7766_buffer_setup_ops);
> +					      &iio_pollfunc_store_time,
> +					      &ad7766_trigger_handler,
> +					      &ad7766_buffer_setup_ops);
>  	if (ret)
>  		return ret;
>  


      parent reply	other threads:[~2019-04-04 19:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-24 21:40 [PATCH] iio: adc: ad7766: Change alignment to match paranthesis Camylla Gonçalves Cantanheide
2019-03-03 13:32 ` Jonathan Cameron
2019-04-04 19:59 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404205946.5d5b0a88@archlinux \
    --to=jic23@kernel.org \
    --cc=c.cantanheide@gmail.com \
    --cc=kernel-usp@googlegroups.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).