From: Jonathan Cameron <jic23@kernel.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Chris Healy <cphealy@gmail.com>,
linux-kernel@vger.kernel.org,
Haibo Chen <haibo.chen@freescale.com>
Subject: Re: [PATCH 2/6] iio: imx7d_adc: Replace pr_err with dev_err
Date: Sun, 7 Apr 2019 12:03:49 +0100 [thread overview]
Message-ID: <20190407120349.0215fd71@archlinux> (raw)
In-Reply-To: <20190403070325.1077-3-andrew.smirnov@gmail.com>
On Wed, 3 Apr 2019 00:03:21 -0700
Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
> Replace combination of pr_err()/dev_name() with an equivalent call for
> dev_err().
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: linux-iio@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
Applied, thanks,
Jonathan
> ---
> drivers/iio/adc/imx7d_adc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c
> index 3bbd657409d5..72cfe9834bcb 100644
> --- a/drivers/iio/adc/imx7d_adc.c
> +++ b/drivers/iio/adc/imx7d_adc.c
> @@ -388,8 +388,9 @@ static irqreturn_t imx7d_adc_isr(int irq, void *dev_id)
> * timeout flags.
> */
> if (status & IMX7D_REG_ADC_INT_STATUS_CHANNEL_CONV_TIME_OUT) {
> - pr_err("%s: ADC got conversion time out interrupt: 0x%08x\n",
> - dev_name(info->dev), status);
> + dev_err(info->dev,
> + "ADC got conversion time out interrupt: 0x%08x\n",
> + status);
> status &= ~IMX7D_REG_ADC_INT_STATUS_CHANNEL_CONV_TIME_OUT;
> writel(status, info->regs + IMX7D_REG_ADC_INT_STATUS);
> }
next prev parent reply other threads:[~2019-04-07 11:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 7:03 [PATCH 0/6] i.MX7D ADC improvements Andrey Smirnov
2019-04-03 7:03 ` [PATCH 1/6] iio: imx7d_adc: Add local struct device pointer in imx7d_adc_probe() Andrey Smirnov
2019-04-07 11:02 ` Jonathan Cameron
2019-04-03 7:03 ` [PATCH 2/6] iio: imx7d_adc: Replace pr_err with dev_err Andrey Smirnov
2019-04-07 11:03 ` Jonathan Cameron [this message]
2019-04-03 7:03 ` [PATCH 3/6] iio: imx7d_adc: Use devm_iio_device_register() Andrey Smirnov
2019-04-07 11:07 ` Jonathan Cameron
2019-04-14 1:04 ` Andrey Smirnov
2019-04-03 7:03 ` [PATCH 4/6] iio: imx7d_adc: Use devm_platform_ioremap_resource() Andrey Smirnov
2019-04-07 11:09 ` Jonathan Cameron
2019-04-03 7:03 ` [PATCH 5/6] iio: imx7d_adc: Use imx7d_adc_resume() in imx7d_adc_probe() Andrey Smirnov
2019-04-07 11:15 ` Jonathan Cameron
2019-04-14 1:05 ` Andrey Smirnov
2019-04-03 7:03 ` [PATCH 6/6] iio: imx7d_adc: Drop imx7d_adc_remove() Andrey Smirnov
2019-04-07 11:16 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190407120349.0215fd71@archlinux \
--to=jic23@kernel.org \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=haibo.chen@freescale.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).