From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0517DC10F0E for ; Sun, 7 Apr 2019 11:03:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCB9021738 for ; Sun, 7 Apr 2019 11:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554635035; bh=KvtSte/zwqJdwqPVKiN0szfPNy7gcHrfZyIjZuQWHWk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=dYdI2+vM89e+AuylBZo5T66NOiGbtIC+REofB5bzVQPuppOmIOr63JhFbBDQMHApT /bBtSkfwrtf6wPVgzKztOgPwZQymYoy8R8MWp3436A8UZ/OESP0Gl7WvqrHpH8Twhn xeaw1fDGoKxSgC1uvonhmYnor3BOVQrNO771EVRs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726263AbfDGLDz (ORCPT ); Sun, 7 Apr 2019 07:03:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:52128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbfDGLDz (ORCPT ); Sun, 7 Apr 2019 07:03:55 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DCF8620880; Sun, 7 Apr 2019 11:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554635034; bh=KvtSte/zwqJdwqPVKiN0szfPNy7gcHrfZyIjZuQWHWk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jecddVqgOxBuWtyiY7w93FN78+FJ9d6SmGhlN83DlN/vP/LViZj5j5o6yaWDEYozH 7Etv3IrtrBSN5Ov3RqhOFqagB1CiBcRWcNnrPE8fyNAPKZeywTqndsuT0gOipleUKK toLtinALv4Z5hNUygGSrFPXgmxcvWk5xsl/kJtKU= Date: Sun, 7 Apr 2019 12:03:49 +0100 From: Jonathan Cameron To: Andrey Smirnov Cc: linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Chris Healy , linux-kernel@vger.kernel.org, Haibo Chen Subject: Re: [PATCH 2/6] iio: imx7d_adc: Replace pr_err with dev_err Message-ID: <20190407120349.0215fd71@archlinux> In-Reply-To: <20190403070325.1077-3-andrew.smirnov@gmail.com> References: <20190403070325.1077-1-andrew.smirnov@gmail.com> <20190403070325.1077-3-andrew.smirnov@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 3 Apr 2019 00:03:21 -0700 Andrey Smirnov wrote: > Replace combination of pr_err()/dev_name() with an equivalent call for > dev_err(). > > Signed-off-by: Andrey Smirnov > Cc: Jonathan Cameron > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: Peter Meerwald-Stadler > Cc: Chris Healy > Cc: linux-iio@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Applied, thanks, Jonathan > --- > drivers/iio/adc/imx7d_adc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c > index 3bbd657409d5..72cfe9834bcb 100644 > --- a/drivers/iio/adc/imx7d_adc.c > +++ b/drivers/iio/adc/imx7d_adc.c > @@ -388,8 +388,9 @@ static irqreturn_t imx7d_adc_isr(int irq, void *dev_id) > * timeout flags. > */ > if (status & IMX7D_REG_ADC_INT_STATUS_CHANNEL_CONV_TIME_OUT) { > - pr_err("%s: ADC got conversion time out interrupt: 0x%08x\n", > - dev_name(info->dev), status); > + dev_err(info->dev, > + "ADC got conversion time out interrupt: 0x%08x\n", > + status); > status &= ~IMX7D_REG_ADC_INT_STATUS_CHANNEL_CONV_TIME_OUT; > writel(status, info->regs + IMX7D_REG_ADC_INT_STATUS); > }