From: Jonathan Cameron <jic23@kernel.org>
To: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
stefan.popa@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-usp@googlegroups.com
Subject: Re: [PATCH 1/4] staging: iio: ad9832: organize includes
Date: Sun, 7 Apr 2019 12:31:52 +0100 [thread overview]
Message-ID: <20190407123152.79fa8e8a@archlinux> (raw)
In-Reply-To: <20190401143710.ruubi2knbjsjzdm7@smtp.gmail.com>
On Mon, 1 Apr 2019 11:37:10 -0300
Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:
> Organize includes to list them in lexicographic order.
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
There are a few headers in there that I'd expect to be unnecessary once
cleanup on the driver is finished, but good to get them in a nice
order to start with.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/frequency/ad9832.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index a3ce50427724..50a583020072 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -6,22 +6,24 @@
> * Licensed under the GPL-2.
> */
>
> +#include <asm/div64.h>
> +
> #include <linux/device.h>
> +#include <linux/err.h>
> #include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/regulator/consumer.h>
> #include <linux/slab.h>
> -#include <linux/sysfs.h>
> #include <linux/spi/spi.h>
> -#include <linux/regulator/consumer.h>
> -#include <linux/err.h>
> -#include <linux/module.h>
> -#include <asm/div64.h>
> +#include <linux/sysfs.h>
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dds.h"
>
> #include "ad9832.h"
>
> +#include "dds.h"
> +
> /* Registers */
>
> #define AD9832_FREQ0LL 0x0
prev parent reply other threads:[~2019-04-07 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 14:37 [PATCH 1/4] staging: iio: ad9832: organize includes Marcelo Schmitt
2019-04-07 11:31 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190407123152.79fa8e8a@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).