From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E370C282CE for ; Sun, 14 Apr 2019 13:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CB5C218FC for ; Sun, 14 Apr 2019 13:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555249296; bh=out+XRsIKPsZREkj0qDPaaiw/4RTQBb28Qc52VhaR0Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=fXQHv5nlQ22Qs8SNsD/TC4/umy/qbh8mIrPKQYecXAGOlrXbsnVshVWsN1j5xataj C4J9A3WyG13VZghaHcLzFMGflqRPb0a+d8LHDnZy5ahqHUCsCShdOfKviKc1tpYRC2 T5AvRoSDkPDdaFR8v/ioYSrNkzSM7+79SJDV1Tj8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726305AbfDNNlg (ORCPT ); Sun, 14 Apr 2019 09:41:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:47464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbfDNNlf (ORCPT ); Sun, 14 Apr 2019 09:41:35 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0F78218D3; Sun, 14 Apr 2019 13:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555249294; bh=out+XRsIKPsZREkj0qDPaaiw/4RTQBb28Qc52VhaR0Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tMXdfH3IuFNdI+/BRxBfl0pfOXrYkdkaPo6s1kZd2n3Whm6E+DOx8aT4T+7yZCWEF m9D58Magac6EitBDGNBWNJinW18ZrsOZF+dWSoBorebtTmBCmk9UCnoIB+FzetbDB0 6Sin44LVD1k0okacx532XJVZDhP4fvY2Z+24lsak= Date: Sun, 14 Apr 2019 14:39:37 +0100 From: Jonathan Cameron To: Rui Miguel Silva Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Shawn Guo , Rob Herring , Fabio Estevam , linux-iio@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 4/6] iio: gyro: fxas21002c: add spi driver Message-ID: <20190414143937.144df168@archlinux> In-Reply-To: <20190412164901.2321-5-rui.silva@linaro.org> References: <20190412164901.2321-1-rui.silva@linaro.org> <20190412164901.2321-5-rui.silva@linaro.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 12 Apr 2019 17:48:59 +0100 Rui Miguel Silva wrote: > Add driver to talk over spi to a fxas21002c gyroscope device and use > the core as main controller. > > Signed-off-by: Rui Miguel Silva Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/gyro/Kconfig | 7 +++- > drivers/iio/gyro/Makefile | 1 + > drivers/iio/gyro/fxas21002c_spi.c | 70 +++++++++++++++++++++++++++++++ > 3 files changed, 77 insertions(+), 1 deletion(-) > create mode 100644 drivers/iio/gyro/fxas21002c_spi.c > > diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig > index 71b6552ee06b..61c00cee037d 100644 > --- a/drivers/iio/gyro/Kconfig > +++ b/drivers/iio/gyro/Kconfig > @@ -78,7 +78,8 @@ config FXAS21002C > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > select FXAS21002C_I2C if (I2C) > - depends on I2C > + select FXAS21002C_SPI if (SPI) > + depends on (I2C || SPI_MASTER) > help > Say yes here to build support for NXP FXAS21002C Tri-axis Gyro > Sensor driver connected via I2C or SPI. > @@ -90,6 +91,10 @@ config FXAS21002C_I2C > tristate > select REGMAP_I2C > > +config FXAS21002C_SPI > + tristate > + select REGMAP_SPI > + > config HID_SENSOR_GYRO_3D > depends on HID_SENSOR_HUB > select IIO_BUFFER > diff --git a/drivers/iio/gyro/Makefile b/drivers/iio/gyro/Makefile > index adc18a5eb283..45cbd5dc644e 100644 > --- a/drivers/iio/gyro/Makefile > +++ b/drivers/iio/gyro/Makefile > @@ -14,6 +14,7 @@ obj-$(CONFIG_BMG160_I2C) += bmg160_i2c.o > obj-$(CONFIG_BMG160_SPI) += bmg160_spi.o > obj-$(CONFIG_FXAS21002C) += fxas21002c_core.o > obj-$(CONFIG_FXAS21002C_I2C) += fxas21002c_i2c.o > +obj-$(CONFIG_FXAS21002C_SPI) += fxas21002c_spi.o > > obj-$(CONFIG_HID_SENSOR_GYRO_3D) += hid-sensor-gyro-3d.o > > diff --git a/drivers/iio/gyro/fxas21002c_spi.c b/drivers/iio/gyro/fxas21002c_spi.c > new file mode 100644 > index 000000000000..77ceebef4e34 > --- /dev/null > +++ b/drivers/iio/gyro/fxas21002c_spi.c > @@ -0,0 +1,70 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Driver for NXP Fxas21002c Gyroscope - SPI > + * > + * Copyright (C) 2019 Linaro Ltd. > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#include "fxas21002c.h" > + > +static const struct regmap_config fxas21002c_regmap_spi_conf = { > + .reg_bits = 8, > + .val_bits = 8, > + .max_register = FXAS21002C_REG_CTRL3, > +}; > + > +static int fxas21002c_spi_probe(struct spi_device *spi) > +{ > + const struct spi_device_id *id = spi_get_device_id(spi); > + struct regmap *regmap; > + > + regmap = devm_regmap_init_spi(spi, &fxas21002c_regmap_spi_conf); > + if (IS_ERR(regmap)) { > + dev_err(&spi->dev, "Failed to register spi regmap: %ld\n", > + PTR_ERR(regmap)); > + return PTR_ERR(regmap); > + } > + > + return fxas21002c_core_probe(&spi->dev, regmap, spi->irq, id->name); > +} > + > +static int fxas21002c_spi_remove(struct spi_device *spi) > +{ > + fxas21002c_core_remove(&spi->dev); > + > + return 0; > +} > + > +static const struct spi_device_id fxas21002c_spi_id[] = { > + { "fxas21002c", 0 }, > + { } > +}; > +MODULE_DEVICE_TABLE(spi, fxas21002c_spi_id); > + > +static const struct of_device_id fxas21002c_spi_of_match[] = { > + { .compatible = "nxp,fxas21002c", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, fxas21002c_spi_of_match); > + > +static struct spi_driver fxas21002c_spi_driver = { > + .driver = { > + .name = "fxas21002c_spi", > + .pm = &fxas21002c_pm_ops, > + .of_match_table = fxas21002c_spi_of_match, > + }, > + .probe = fxas21002c_spi_probe, > + .remove = fxas21002c_spi_remove, > + .id_table = fxas21002c_spi_id, > +}; > +module_spi_driver(fxas21002c_spi_driver); > + > +MODULE_AUTHOR("Rui Miguel Silva "); > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("FXAS21002C SPI Gyro driver");