From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
<linux-iio@vger.kernel.org>
Subject: Re: [PATCH next 08/25] iio: adc: at91: Use dev_get_drvdata()
Date: Sat, 27 Apr 2019 13:07:22 +0100 [thread overview]
Message-ID: <20190427130722.70ec290b@archlinux> (raw)
In-Reply-To: <20190423075020.173734-9-wangkefeng.wang@huawei.com>
On Tue, 23 Apr 2019 15:50:03 +0800
Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> Using dev_get_drvdata directly.
>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: linux-iio@vger.kernel.org
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
A sensible cleanup, thanks.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/at91-sama5d2_adc.c | 12 ++++--------
> drivers/iio/adc/at91_adc.c | 4 ++--
> 2 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index d5ea84cf6460..a3a4ca946308 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -1586,8 +1586,7 @@ static void at91_adc_hw_init(struct at91_adc_state *st)
> static ssize_t at91_adc_get_fifo_state(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> - struct iio_dev *indio_dev =
> - platform_get_drvdata(to_platform_device(dev));
> + struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct at91_adc_state *st = iio_priv(indio_dev);
>
> return scnprintf(buf, PAGE_SIZE, "%d\n", !!st->dma_st.dma_chan);
> @@ -1596,8 +1595,7 @@ static ssize_t at91_adc_get_fifo_state(struct device *dev,
> static ssize_t at91_adc_get_watermark(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> - struct iio_dev *indio_dev =
> - platform_get_drvdata(to_platform_device(dev));
> + struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct at91_adc_state *st = iio_priv(indio_dev);
>
> return scnprintf(buf, PAGE_SIZE, "%d\n", st->dma_st.watermark);
> @@ -1849,8 +1847,7 @@ static int at91_adc_remove(struct platform_device *pdev)
>
> static __maybe_unused int at91_adc_suspend(struct device *dev)
> {
> - struct iio_dev *indio_dev =
> - platform_get_drvdata(to_platform_device(dev));
> + struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct at91_adc_state *st = iio_priv(indio_dev);
>
> /*
> @@ -1870,8 +1867,7 @@ static __maybe_unused int at91_adc_suspend(struct device *dev)
>
> static __maybe_unused int at91_adc_resume(struct device *dev)
> {
> - struct iio_dev *indio_dev =
> - platform_get_drvdata(to_platform_device(dev));
> + struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct at91_adc_state *st = iio_priv(indio_dev);
> int ret;
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 596841a3c4db..1aa8af3491fd 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -1360,7 +1360,7 @@ static int at91_adc_remove(struct platform_device *pdev)
> #ifdef CONFIG_PM_SLEEP
> static int at91_adc_suspend(struct device *dev)
> {
> - struct iio_dev *idev = platform_get_drvdata(to_platform_device(dev));
> + struct iio_dev *idev = dev_get_drvdata(dev);
> struct at91_adc_state *st = iio_priv(idev);
>
> pinctrl_pm_select_sleep_state(dev);
> @@ -1371,7 +1371,7 @@ static int at91_adc_suspend(struct device *dev)
>
> static int at91_adc_resume(struct device *dev)
> {
> - struct iio_dev *idev = platform_get_drvdata(to_platform_device(dev));
> + struct iio_dev *idev = dev_get_drvdata(dev);
> struct at91_adc_state *st = iio_priv(idev);
>
> clk_prepare_enable(st->clk);
prev parent reply other threads:[~2019-04-27 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190423075020.173734-1-wangkefeng.wang@huawei.com>
2019-04-23 7:50 ` [PATCH next 08/25] iio: adc: at91: Use dev_get_drvdata() Kefeng Wang
2019-04-27 12:07 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427130722.70ec290b@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=Jonathan.Cameron@huawei.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox