From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC42C43218 for ; Sat, 27 Apr 2019 13:08:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F624208CB for ; Sat, 27 Apr 2019 13:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556370528; bh=jnM29zihc11tw81fyprayFzfy6HR3G1+ASCKRlaGmIs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=bljtLpoGiA2N+1YfC3UCi2FFSJYaDlqez+WkdN+i6NoK4t3vAV9fBdd0+kWaNy7Ax dFgCzemsdjppwwpXKplXPMfsNvaRvjv4vyjynAFY7J52Axnmgi6xr7kvQEW2vMKCe7 TP873jzki2Cx04Y4G4ajYrX4tDKy/CCXpTXo2BEU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbfD0NIr (ORCPT ); Sat, 27 Apr 2019 09:08:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:60620 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbfD0NIr (ORCPT ); Sat, 27 Apr 2019 09:08:47 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4745E208C2; Sat, 27 Apr 2019 13:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556370526; bh=jnM29zihc11tw81fyprayFzfy6HR3G1+ASCKRlaGmIs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qJiuiipfOPiLp/ykpz8Fkv25u4WxlQUI9m3oqzrpZOVw9/xJY+M68FkZ/daQHCsh+ M/4nS3olJgIYBPhut20Pt3e7pQWLp7v3VN++Xu6gRPiew2j0dPZPj4LlEF/4tEDZ3c WXMDbv3W8UR4UGwg+LT6nuREnmGOHthrT00jETj8= Date: Sat, 27 Apr 2019 14:08:40 +0100 From: Jonathan Cameron To: Fabrice Gasnier Cc: Fabien Dessenne , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Maxime Coquelin , Alexandre Torgue , , , , Subject: Re: [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case Message-ID: <20190427140840.38acb922@archlinux> In-Reply-To: References: <1556110286-1526-1-git-send-email-fabien.dessenne@st.com> <1556110286-1526-2-git-send-email-fabien.dessenne@st.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 24 Apr 2019 14:55:09 +0200 Fabrice Gasnier wrote: > On 4/24/19 2:51 PM, Fabien Dessenne wrote: > > During probe, check the "get_irq" error value. > > > > Signed-off-by: Fabien Dessenne > > --- > > Hi Fabien, > > Acked-by: Fabrice Gasnier Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > Thanks, > Fabrice > > > drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > > index 19adc2b..588907c 100644 > > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > > @@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev) > > * So IRQ associated to filter instance 0 is dedicated to the Filter 0. > > */ > > irq = platform_get_irq(pdev, 0); > > + if (irq < 0) { > > + if (irq != -EPROBE_DEFER) > > + dev_err(dev, "Failed to get IRQ: %d\n", irq); > > + return irq; > > + } > > + > > ret = devm_request_irq(dev, irq, stm32_dfsdm_irq, > > 0, pdev->name, adc); > > if (ret < 0) { > >