From: Jonathan Cameron <jic23@kernel.org>
To: Vatsala Narang <vatsalanarang@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
julia.lawall@lip6.fr
Subject: Re: [PATCH] staging: iio: adc: Add paragraph to describe Kconfig symbol
Date: Sun, 5 May 2019 13:12:07 +0100 [thread overview]
Message-ID: <20190505131207.69fb59ef@archlinux> (raw)
In-Reply-To: <20190501071541.4734-1-vatsalanarang@gmail.com>
On Wed, 1 May 2019 12:45:41 +0530
Vatsala Narang <vatsalanarang@gmail.com> wrote:
> This patch updates Kconfig with paragraph that describe config symbol
> fully.Issue addressed by checkpatch.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
I'm not a great fan of that particular checkpatch warning as sometimes it
leads to silly details being added to things that really can be described
in very little text.
In this particular case the additional element of the module name seems
worth having though so applied to the togreg branch of iio.git and pushed
out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
> index 23d9a655a520..31cd9a12f40f 100644
> --- a/drivers/staging/iio/adc/Kconfig
> +++ b/drivers/staging/iio/adc/Kconfig
> @@ -12,6 +12,9 @@ config AD7816
> Say yes here to build support for Analog Devices AD7816/7/8
> temperature sensors and ADC.
>
> + To compile this driver as a module, choose M here: the
> + module will be called ad7816.
> +
> config AD7192
> tristate "Analog Devices AD7190 AD7192 AD7193 AD7195 ADC driver"
> depends on SPI
prev parent reply other threads:[~2019-05-05 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 7:15 [PATCH] staging: iio: adc: Add paragraph to describe Kconfig symbol Vatsala Narang
2019-05-05 12:12 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190505131207.69fb59ef@archlinux \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vatsalanarang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).