From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: mcp3422: fix of match table
Date: Sat, 11 May 2019 10:54:50 +0100 [thread overview]
Message-ID: <20190511105450.544808d7@archlinux> (raw)
In-Reply-To: <1557258335-9863-1-git-send-email-angelo@amarulasolutions.com>
On Tue, 7 May 2019 21:45:35 +0200
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> In order to support all the chip variants in dts, compatible should
> explicitly list all the variants and not only the base one.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
These should have a manufacturer prefix.
Note that the fallback path to the id_table will work anyway
for these devices so whilst it is good to tidy this up there
isn't any great urgency.
Jonathan
> ---
> drivers/iio/adc/mcp3422.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c
> index 63de705..91d6be3 100644
> --- a/drivers/iio/adc/mcp3422.c
> +++ b/drivers/iio/adc/mcp3422.c
> @@ -410,7 +410,14 @@ MODULE_DEVICE_TABLE(i2c, mcp3422_id);
>
> #ifdef CONFIG_OF
> static const struct of_device_id mcp3422_of_match[] = {
> + { .compatible = "mcp3421" },
> { .compatible = "mcp3422" },
> + { .compatible = "mcp3423" },
> + { .compatible = "mcp3424" },
> + { .compatible = "mcp3425" },
> + { .compatible = "mcp3426" },
> + { .compatible = "mcp3427" },
> + { .compatible = "mcp3428" },
> { }
> };
> MODULE_DEVICE_TABLE(of, mcp3422_of_match);
prev parent reply other threads:[~2019-05-11 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 19:45 [PATCH] iio: adc: mcp3422: fix of match table Angelo Compagnucci
2019-05-11 9:54 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190511105450.544808d7@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=angelo@amarulasolutions.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox