From: Fabio Estevam <festevam@gmail.com>
To: jic23@kernel.org
Cc: andrew.smirnov@gmail.com, linux-iio@vger.kernel.org,
Fabio Estevam <festevam@gmail.com>
Subject: [PATCH 1/4] iio: imx7d_adc: Remove unneeded error message
Date: Mon, 3 Jun 2019 16:34:30 -0300 [thread overview]
Message-ID: <20190603193433.6394-1-festevam@gmail.com> (raw)
In case of ioremap failure, the core code will take care of printing
the error message, so there is no need for having a local error
message in the driver.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/iio/adc/imx7d_adc.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c
index 4fe97c2a0f43..23c7b0ee945f 100644
--- a/drivers/iio/adc/imx7d_adc.c
+++ b/drivers/iio/adc/imx7d_adc.c
@@ -493,11 +493,8 @@ static int imx7d_adc_probe(struct platform_device *pdev)
info->dev = dev;
info->regs = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(info->regs)) {
- ret = PTR_ERR(info->regs);
- dev_err(dev, "Failed to remap adc memory, err = %d\n", ret);
- return ret;
- }
+ if (IS_ERR(info->regs))
+ return PTR_ERR(info->regs);
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
--
2.17.1
next reply other threads:[~2019-06-03 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 19:34 Fabio Estevam [this message]
2019-06-03 19:34 ` [PATCH 2/4] iio: imx7d_adc: Introduce a definition for the input clock Fabio Estevam
2019-06-08 12:59 ` Jonathan Cameron
2019-06-03 19:34 ` [PATCH 3/4] iio: imx7d_adc: Fit into a single line Fabio Estevam
2019-06-08 13:00 ` Jonathan Cameron
2019-06-03 19:34 ` [PATCH 4/4] iio: imx7d_adc: Remove unneeded 'average_en' member Fabio Estevam
2019-06-08 13:01 ` Jonathan Cameron
2019-06-08 12:58 ` [PATCH 1/4] iio: imx7d_adc: Remove unneeded error message Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603193433.6394-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=andrew.smirnov@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).