From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A23C468BC for ; Sat, 8 Jun 2019 11:55:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63EC1216C4 for ; Sat, 8 Jun 2019 11:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559994936; bh=F6qhJyzp+hpUv2sORpYggFf/Ny8xu1gIsJ0ENP514b0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=dtI2ZQPqeRdA24QPTeCVemsLzpVmVnlfnDY6HfiXc+bnFgTZCF9fX8rolu2rFqSGl WkMFMYCuomvjOV0poYVqqb38FE1w5ss6a/KVScCASkMCwCc/fAhD8/LzB7x5bbxOLq alLOEEDUJUi9V/p5Y/J8tP2BXksAJd2GZ2lh4OHA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbfFHLzf (ORCPT ); Sat, 8 Jun 2019 07:55:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:42502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727217AbfFHLzf (ORCPT ); Sat, 8 Jun 2019 07:55:35 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA00C214AE; Sat, 8 Jun 2019 11:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559994934; bh=F6qhJyzp+hpUv2sORpYggFf/Ny8xu1gIsJ0ENP514b0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=09qiwXFGhaa0dUCKYNylcQjOmR+PZj6LLK6kzr2MTogPnwnqDJrPaCx8UDHx1Lwx5 anuhyP2nWsxCDj5938enn1xIWXRQNmwTkpx3rSeHz960Q2W2l/jrwTHVlsrTVfSgvL 0EKfyn+xGi2R6rlkcc/CCV9rThV12vyKN0KJ6yEU= Date: Sat, 8 Jun 2019 12:55:29 +0100 From: Jonathan Cameron To: Randy Dunlap Cc: Fabio Estevam , lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, preid@electromag.com.au Subject: Re: [PATCH v2] staging: iio: adt7316: Fix build errors when GPIOLIB is not set Message-ID: <20190608125529.6aa5c0a7@archlinux> In-Reply-To: <7edb325e-9af8-8ae8-d26e-da75c0252284@infradead.org> References: <20190606020532.4864-1-festevam@gmail.com> <7edb325e-9af8-8ae8-d26e-da75c0252284@infradead.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 5 Jun 2019 20:24:09 -0700 Randy Dunlap wrote: > On 6/5/19 7:05 PM, Fabio Estevam wrote: > > On x86_64 when GPIOLIB is not set the following build errors > > are seen: > > > > drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] > > drivers/staging/iio/addac/adt7316.c:1805:2: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration] > > > > These functions are provided by the > > and headers, so include them to fix these > > build errors. > > > > While at it, remove as this driver is a GPIO > > consumer and not a GPIO driver. > > > > Reported-by: Randy Dunlap > > Signed-off-by: Fabio Estevam > > Acked-by: Randy Dunlap # build-tested Applied to the fixes-togreg branch of iio.git. thanks, Jonathan > > Thanks. > > > --- > > Changes since v1: > > - Remove - Phil > > > > drivers/staging/iio/addac/adt7316.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c > > index 37ce563cb0e1..9cb3d0e42c38 100644 > > --- a/drivers/staging/iio/addac/adt7316.c > > +++ b/drivers/staging/iio/addac/adt7316.c > > @@ -6,7 +6,8 @@ > > */ > > > > #include > > -#include > > +#include > > +#include > > #include > > #include > > #include > > > >