From: Jonathan Cameron <jic23@kernel.org>
To: Luca Weiss <luca@z3ntu.xyz>
Cc: Martijn Braam <martijn@brixit.nl>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] iio: light: stk3310: Add support for stk3335
Date: Sat, 8 Jun 2019 13:57:10 +0100 [thread overview]
Message-ID: <20190608135710.25117605@archlinux> (raw)
In-Reply-To: <20190603192040.24101-1-luca@z3ntu.xyz>
On Mon, 3 Jun 2019 21:20:39 +0200
Luca Weiss <luca@z3ntu.xyz> wrote:
> From: Martijn Braam <martijn@brixit.nl>
>
> The stk3335 light/proximity sensor is similar to the stk3310 and stk3311
> sensors and works with the stk3310 driver.
>
> Signed-off-by: Martijn Braam <martijn@brixit.nl>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at it.
Thanks,
Jonathan
> ---
> drivers/iio/light/stk3310.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
> index 6e2a169da950..a25cc35f334e 100644
> --- a/drivers/iio/light/stk3310.c
> +++ b/drivers/iio/light/stk3310.c
> @@ -40,6 +40,7 @@
>
> #define STK3310_CHIP_ID_VAL 0x13
> #define STK3311_CHIP_ID_VAL 0x1D
> +#define STK3335_CHIP_ID_VAL 0x51
> #define STK3310_PSINT_EN 0x01
> #define STK3310_PS_MAX_VAL 0xFFFF
>
> @@ -454,7 +455,8 @@ static int stk3310_init(struct iio_dev *indio_dev)
> return ret;
>
> if (chipid != STK3310_CHIP_ID_VAL &&
> - chipid != STK3311_CHIP_ID_VAL) {
> + chipid != STK3311_CHIP_ID_VAL &&
> + chipid != STK3335_CHIP_ID_VAL) {
> dev_err(&client->dev, "invalid chip id: 0x%x\n", chipid);
> return -ENODEV;
> }
> @@ -666,6 +668,7 @@ static SIMPLE_DEV_PM_OPS(stk3310_pm_ops, stk3310_suspend, stk3310_resume);
> static const struct i2c_device_id stk3310_i2c_id[] = {
> {"STK3310", 0},
> {"STK3311", 0},
> + {"STK3335", 0},
> {}
> };
> MODULE_DEVICE_TABLE(i2c, stk3310_i2c_id);
> @@ -673,6 +676,7 @@ MODULE_DEVICE_TABLE(i2c, stk3310_i2c_id);
> static const struct acpi_device_id stk3310_acpi_id[] = {
> {"STK3310", 0},
> {"STK3311", 0},
> + {"STK3335", 0},
> {}
> };
>
prev parent reply other threads:[~2019-06-08 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 19:20 [PATCH] iio: light: stk3310: Add support for stk3335 Luca Weiss
2019-06-08 12:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608135710.25117605@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=martijn@brixit.nl \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).