From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: adis162xx: fix low-power docs & reports
Date: Wed, 26 Jun 2019 19:26:31 +0100 [thread overview]
Message-ID: <20190626192631.7ffa8043@archlinux> (raw)
In-Reply-To: <20190625124840.24542-1-alexandru.ardelean@analog.com>
On Tue, 25 Jun 2019 15:48:40 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> All current ADIS162XX drivers have incorrect values defined via comments.
> Also, when an error is reported the printed value is incorrect.
>
> The functionality itself isn't affected, so it's not a critical issue.
>
> And since the change is trivial, it was included in a single patch that
> fixes these in one go. All values were correlated with the ones specified
> in the data-sheets.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing
for usual reasons.
Thanks,
Jonathan
> ---
> drivers/iio/accel/adis16201.c | 4 ++--
> drivers/iio/accel/adis16209.c | 4 ++--
> drivers/staging/iio/accel/adis16203.c | 4 ++--
> drivers/staging/iio/accel/adis16240.c | 2 +-
> 4 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c
> index 4c1d482ea73a..3257d4d27015 100644
> --- a/drivers/iio/accel/adis16201.c
> +++ b/drivers/iio/accel/adis16201.c
> @@ -71,7 +71,7 @@
> #define ADIS16201_DIAG_STAT_FLASH_UPT_FAIL_BIT 2
> /* Power supply above 3.625 V */
> #define ADIS16201_DIAG_STAT_POWER_HIGH_BIT 1
> -/* Power supply below 3.15 V */
> +/* Power supply below 2.975 V */
> #define ADIS16201_DIAG_STAT_POWER_LOW_BIT 0
>
> /* System Command Register Definition */
> @@ -231,7 +231,7 @@ static const char * const adis16201_status_error_msgs[] = {
> [ADIS16201_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure",
> [ADIS16201_DIAG_STAT_FLASH_UPT_FAIL_BIT] = "Flash update failed",
> [ADIS16201_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V",
> - [ADIS16201_DIAG_STAT_POWER_LOW_BIT] = "Power supply below 3.15V",
> + [ADIS16201_DIAG_STAT_POWER_LOW_BIT] = "Power supply below 2.975V",
> };
>
> static const struct adis_data adis16201_data = {
> diff --git a/drivers/iio/accel/adis16209.c b/drivers/iio/accel/adis16209.c
> index f2dc3a5f0463..01dd02f7e1d6 100644
> --- a/drivers/iio/accel/adis16209.c
> +++ b/drivers/iio/accel/adis16209.c
> @@ -73,7 +73,7 @@
> #define ADIS16209_STAT_FLASH_UPT_FAIL_BIT 2
> /* Power supply above 3.625 V */
> #define ADIS16209_STAT_POWER_HIGH_BIT 1
> -/* Power supply below 3.15 V */
> +/* Power supply below 2.975 V */
> #define ADIS16209_STAT_POWER_LOW_BIT 0
>
> #define ADIS16209_CMD_REG 0x3E
> @@ -241,7 +241,7 @@ static const char * const adis16209_status_error_msgs[] = {
> [ADIS16209_STAT_SPI_FAIL_BIT] = "SPI failure",
> [ADIS16209_STAT_FLASH_UPT_FAIL_BIT] = "Flash update failed",
> [ADIS16209_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V",
> - [ADIS16209_STAT_POWER_LOW_BIT] = "Power supply below 3.15V",
> + [ADIS16209_STAT_POWER_LOW_BIT] = "Power supply below 2.975V",
> };
>
> static const struct adis_data adis16209_data = {
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index a5d974ac2e3b..39687139a7d3 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -122,7 +122,7 @@
> /* Power supply above 3.625 V */
> #define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1
>
> -/* Power supply below 3.15 V */
> +/* Power supply below 2.975 V */
> #define ADIS16203_DIAG_STAT_POWER_LOW_BIT 0
>
> /* GLOB_CMD */
> @@ -234,7 +234,7 @@ static const char * const adis16203_status_error_msgs[] = {
> [ADIS16203_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure",
> [ADIS16203_DIAG_STAT_FLASH_UPT_BIT] = "Flash update failed",
> [ADIS16203_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V",
> - [ADIS16203_DIAG_STAT_POWER_LOW_BIT] = "Power supply below 3.15V",
> + [ADIS16203_DIAG_STAT_POWER_LOW_BIT] = "Power supply below 2.975V",
> };
>
> static const struct adis_data adis16203_data = {
> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> index b80c8529784b..62f4b3b1b457 100644
> --- a/drivers/staging/iio/accel/adis16240.c
> +++ b/drivers/staging/iio/accel/adis16240.c
> @@ -175,7 +175,7 @@
> /* Power supply above 3.625 V */
> #define ADIS16240_DIAG_STAT_POWER_HIGH_BIT 1
>
> - /* Power supply below 3.15 V */
> + /* Power supply below 2.225 V */
> #define ADIS16240_DIAG_STAT_POWER_LOW_BIT 0
>
> /* GLOB_CMD */
prev parent reply other threads:[~2019-06-26 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 12:48 [PATCH] iio: adis162xx: fix low-power docs & reports Alexandru Ardelean
2019-06-26 18:26 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626192631.7ffa8043@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=alexandru.ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox